Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Side by Side Diff: chrome/common/mac/app_mode_common.h

Issue 1016543004: [Mac] Use the app's version as the app shim bundle version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use GetVersionForDisplay. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/mac/app_mode_chrome_locator.mm ('k') | chrome/common/mac/app_mode_common.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_MAC_APP_MODE_COMMON_H_ 5 #ifndef CHROME_COMMON_MAC_APP_MODE_COMMON_H_
6 #define CHROME_COMMON_MAC_APP_MODE_COMMON_H_ 6 #define CHROME_COMMON_MAC_APP_MODE_COMMON_H_
7 7
8 #import <Foundation/Foundation.h> 8 #import <Foundation/Foundation.h>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 extern NSString* const kCFBundleTypeIconFileKey; 59 extern NSString* const kCFBundleTypeIconFileKey;
60 extern NSString* const kCFBundleTypeNameKey; 60 extern NSString* const kCFBundleTypeNameKey;
61 extern NSString* const kCFBundleTypeMIMETypesKey; 61 extern NSString* const kCFBundleTypeMIMETypesKey;
62 extern NSString* const kCFBundleTypeRoleKey; 62 extern NSString* const kCFBundleTypeRoleKey;
63 extern NSString* const kBundleTypeRoleViewer; 63 extern NSString* const kBundleTypeRoleViewer;
64 64
65 // The display name of the bundle as shown in Finder and the Dock. For localized 65 // The display name of the bundle as shown in Finder and the Dock. For localized
66 // bundles, this overrides the bundle's file name. 66 // bundles, this overrides the bundle's file name.
67 extern NSString* const kCFBundleDisplayNameKey; 67 extern NSString* const kCFBundleDisplayNameKey;
68 68
69 // The Chrome version string in the app shim bundle. 69 // When Chrome is built, any app bundles (e.g. the app shim template bundle)
70 // will have their CFBundleShortVersionString set to the full version string of
71 // that build. Since, this string is used by OSX when displaying an app bundle's
72 // version, we override it in app shim bundles to show the app's version
73 // instead.
70 extern NSString* const kCFBundleShortVersionStringKey; 74 extern NSString* const kCFBundleShortVersionStringKey;
71 75
76 // Key for the Chrome version that built the app shim bundle. This needs to be
77 // added since we override CFBundleShortVersionString with the version of the
78 // app.
79 extern NSString* const kCrBundleVersionKey;
80
72 // The key specifying whether the display name should be localized. This makes 81 // The key specifying whether the display name should be localized. This makes
73 // Finder look in localization folders in the app bundle for a display name. 82 // Finder look in localization folders in the app bundle for a display name.
74 // (e.g. Content/Resources/en.lproj/) 83 // (e.g. Content/Resources/en.lproj/)
75 extern NSString* const kLSHasLocalizedDisplayNameKey; 84 extern NSString* const kLSHasLocalizedDisplayNameKey;
76 85
77 // The key under which the browser's bundle ID will be stored in the 86 // The key under which the browser's bundle ID will be stored in the
78 // app mode launcher bundle's Info.plist. 87 // app mode launcher bundle's Info.plist.
79 extern NSString* const kBrowserBundleIDKey; 88 extern NSString* const kBrowserBundleIDKey;
80 89
81 // Key for the shortcut ID. 90 // Key for the shortcut ID.
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 base::FilePath profile_dir; 167 base::FilePath profile_dir;
159 }; 168 };
160 169
161 // Check that the socket and its parent directory have the correct permissions 170 // Check that the socket and its parent directory have the correct permissions
162 // and are owned by the user. 171 // and are owned by the user.
163 void VerifySocketPermissions(const base::FilePath& socket_path); 172 void VerifySocketPermissions(const base::FilePath& socket_path);
164 173
165 } // namespace app_mode 174 } // namespace app_mode
166 175
167 #endif // CHROME_COMMON_MAC_APP_MODE_COMMON_H_ 176 #endif // CHROME_COMMON_MAC_APP_MODE_COMMON_H_
OLDNEW
« no previous file with comments | « chrome/common/mac/app_mode_chrome_locator.mm ('k') | chrome/common/mac/app_mode_common.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698