chrome/browser/web_applications/web_app.h - Issue 1016543004: [Mac] Use the app's version as the app shim bundle version.

Unified Diff: chrome/browser/web_applications/web_app.h

Issue 1016543004: [Mac] Use the app's version as the app shim bundle version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/web_applications/web_app.h

diff --git a/chrome/browser/web_applications/web_app.h b/chrome/browser/web_applications/web_app.h

index 0b201acb000192a3c8fe6d929ac38ecdd42c31b9..6fdde4e3adae423f84e981a9d5d9312a9c5f2dc5 100644

--- a/chrome/browser/web_applications/web_app.h

+++ b/chrome/browser/web_applications/web_app.h

@@ -11,6 +11,7 @@

#include "base/callback.h"

#include "base/files/file_path.h"

#include "base/strings/string16.h"

+#include "base/version.h"

#include "build/build_config.h"

#include "chrome/browser/shell_integration.h"

#include "chrome/common/web_application_info.h"

@@ -52,6 +53,7 @@ struct ShortcutInfo {

gfx::ImageFamily favicon;

base::FilePath profile_path;

std::string profile_name;

+ base::Version version;

tapted 2015/03/18 01:49:59 There's a comment on the bug about using a string,

jackhou1 2015/03/18 04:43:48 Yeah, I considered this. Setting an arbitrary stri

tapted 2015/03/19 04:10:20 Yeah I agree with you. And there doesn't seem to b

jackhou1 2015/03/23 03:37:15 Done.

};

// This specifies a folder in the system applications menu (e.g the Start Menu

« no previous file with comments | « no previous file | chrome/browser/web_applications/web_app.cc » ('j') | chrome/common/mac/app_mode_chrome_locator.mm » ('J')