[Mac] Use the app's version as the app shim bundle version.

chrome/browser/web_applications/web_app.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_
 #define CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_
 
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/strings/string16.h"
+#include "base/version.h"
 #include "build/build_config.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/common/web_application_info.h"
 #include "extensions/common/manifest_handlers/file_handler_info.h"
 
 class Profile;
 
 namespace content {
 class WebContents;
 }
@@ skipping 21 matching lines @@
   // and the launch url will be detected at start-up. In this case, |url|
   // is still used to generate the app id (windows app id, not chrome app id).
   std::string extension_id;
   bool is_platform_app;
   base::string16 title;
   base::string16 description;
   base::FilePath extension_path;
   gfx::ImageFamily favicon;
   base::FilePath profile_path;
   std::string profile_name;
+  base::Version version;

[tapted, 2015/03/18 01:49:59]

There's a comment on the bug about using a string, version_name. I think that
trend comes from Android, and it's becoming more common on web apps.

[jackhou1, 2015/03/18 04:43:48]

Yeah, I considered this. Setting an arbitrary string seems to work, but Apple's
documentation says it should be a 3-part version string:

https://developer.apple.com/library/ios/documentation/General/Reference/InfoP...

There's also a comment here indicating that this is enforced on IOS, and for
CFBundleVersion:

https://code.google.com/p/chromium/codesearch#chromium/src/base/file_version_...

So I'm vaguely worried that it'll become enforced. But if that happens we'd have
to truncate the base::Version's 4th part anyway. Since it's only for display
purposes, maybe we should just use GetVersionForDisplay() and change it if we
ever have to. WDYT?

[tapted, 2015/03/19 04:10:20]

Yeah I agree with you. And there doesn't seem to be another good key choice for
putting in a string.

[jackhou1, 2015/03/23 03:37:15]

Done.

 };
 
 // This specifies a folder in the system applications menu (e.g the Start Menu
 // on Windows).
 //
 // These represent the applications menu root, the "Google Chrome" folder and
 // the "Chrome Apps" folder respectively.
 //
 // APP_MENU_LOCATION_HIDDEN specifies a shortcut that is used to register the
 // app with the OS (in order to give its windows shelf icons, and correct icons
@@ skipping 199 matching lines @@
 
 // Sanitizes |name| and returns a version of it that is safe to use as an
 // on-disk file name .
 base::FilePath GetSanitizedFileName(const base::string16& name);
 
 }  // namespace internals
 
 }  // namespace web_app
 
 #endif  // CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_