Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1016423003: Reland "Handle unsucessful JsonPrefStore initialization in SupervisedUserSettingsService." (Closed)

Created:
5 years, 9 months ago by Bernhard Bauer
Modified:
5 years, 9 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, pam+watch_chromium.org, dxie
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Handle unsucessful JsonPrefStore initialization in SupervisedUserSettingsService." > According to crash reports, it's not very common but still possible for the JsonPrefStore used by SupervisedUserSettingsService to fail initialization (which happens if the profile directory doesn't exist). Review URL: https://codereview.chromium.org/960233003 This reverts commit 3490af836c15f44229dedea4b3d80c1869d6e1fe. TBR=treib@chromium.org BUG=463646 Committed: https://crrev.com/4f3a803c5fcdd82dfb7e6a134106ddde1dd7525c Cr-Commit-Position: refs/heads/master@{#322105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/browser/supervised_user/supervised_user_settings_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service.cc View 4 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bernhard Bauer
Marc: TBR (reland with no changes to the original version)
5 years, 9 months ago (2015-03-24 22:03:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016423003/1
5 years, 9 months ago (2015-03-24 22:03:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 00:44:58 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 00:46:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f3a803c5fcdd82dfb7e6a134106ddde1dd7525c
Cr-Commit-Position: refs/heads/master@{#322105}

Powered by Google App Engine
This is Rietveld 408576698