Handle unsucessful JsonPrefStore initialization in SupervisedUserSettingsService.

Handle unsucessful JsonPrefStore initialization in SupervisedUserSettingsService.

According to crash reports, it's not very common but still possible for the JsonPrefStore used by SupervisedUserSettingsService to fail initialization (which happens if the profile directory doesn't exist).

BUG=425785
Committed: https://crrev.com/0197d5dfe8b8105b0263dbe80f6079020a6ccf5d
Cr-Commit-Position: refs/heads/master@{#318460}

[Bernhard Bauer, 2015-02-27 15:30:37]

bauerb@chromium.org changed reviewers:
+ treib@chromium.org

[Bernhard Bauer, 2015-02-27 15:30:37]

Please review!

[Marc Treib, 2015-02-27 15:51:43]

https://codereview.chromium.org/960233003/diff/1/chrome/browser/supervised_us...
File chrome/browser/supervised_user/supervised_user_settings_service.cc (right):

https://codereview.chromium.org/960233003/diff/1/chrome/browser/supervised_us...
chrome/browser/supervised_user/supervised_user_settings_service.cc:74:
CHECK(store_->IsInitializationComplete());
Do you need to handle a failing PrefStore initialization here as well?

[Bernhard Bauer, 2015-02-27 16:03:44]

https://codereview.chromium.org/960233003/diff/1/chrome/browser/supervised_us...
File chrome/browser/supervised_user/supervised_user_settings_service.cc (right):

https://codereview.chromium.org/960233003/diff/1/chrome/browser/supervised_us...
chrome/browser/supervised_user/supervised_user_settings_service.cc:74:
CHECK(store_->IsInitializationComplete());
On 2015/02/27 15:51:43, Marc Treib wrote:
> Do you need to handle a failing PrefStore initialization here as well?

Interestingly enough, this CHECK does not seem to fail (I could imagine because
if the profile directory doesn't exist, the synchronous case already fails
before that). I'm tempted to keep the CHECK at least while this bug is still
investigated, so that we learn if that assumption turns out not to be the case.

[Marc Treib, 2015-02-27 16:08:32]

https://codereview.chromium.org/960233003/diff/1/chrome/browser/supervised_us...
File chrome/browser/supervised_user/supervised_user_settings_service.cc (right):

https://codereview.chromium.org/960233003/diff/1/chrome/browser/supervised_us...
chrome/browser/supervised_user/supervised_user_settings_service.cc:74:
CHECK(store_->IsInitializationComplete());
On 2015/02/27 16:03:44, Bernhard Bauer wrote:
> On 2015/02/27 15:51:43, Marc Treib wrote:
> > Do you need to handle a failing PrefStore initialization here as well?
> 
> Interestingly enough, this CHECK does not seem to fail (I could imagine
because
> if the profile directory doesn't exist, the synchronous case already fails
> before that). I'm tempted to keep the CHECK at least while this bug is still
> investigated, so that we learn if that assumption turns out not to be the
case.

Okay, fair enough. LGTM then.

[Bernhard Bauer, 2015-02-27 16:12:12]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2015-02-27 16:12:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960233003/1

[commit-bot: I haz the power, 2015-02-27 16:17:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-27 16:17:50]

Patchset 1 (id:??) landed as
https://crrev.com/0197d5dfe8b8105b0263dbe80f6079020a6ccf5d
Cr-Commit-Position: refs/heads/master@{#318460}