Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1016173002: Revert of Fix for menus blocking user activity detection (Retry). (Closed)

Created:
5 years, 9 months ago by afakhry
Modified:
5 years, 9 months ago
Reviewers:
sadrul, spang
CC:
chromium-reviews, ozone-reviews_chromium.org, kalyank, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix for menus blocking user activity detection (Retry). (patchset #1 id:1 of https://codereview.chromium.org/1013003002/) Reason for revert: Issue 468442 has resulted from this CL. A fix at a higher level must be done before this CL can be relanded. Original issue's description: > Fix for menus blocking user activity detection (Retry). > > Original CL reverted here: https://codereview.chromium.org/998603003/ > > Menus used to block detecting user activity. The fix works by making the > UserActivityDetector a PlatformEventObserver rather than an > EventHandler. > Also made sure that PlatformEventSource has an instance in > ozone_platform_test.cc > > TBR=oshima@chromium.org,jamescook@chromium.org > R=sadrul@chromium.org,alexst@chromium.org > BUG=462735 > TEST=ui_base_unittests --gtest_filter=UserActivityDetectorTest.* > > Committed: https://crrev.com/00e8cbeb43eb3cc99ffed3bc29a8a539dfece0a6 > Cr-Commit-Position: refs/heads/master@{#321066} TBR=sadrul@chromium.org,spang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462735 Committed: https://crrev.com/6e505f2145d83f58988c17640db50c21639bb8c8 Cr-Commit-Position: refs/heads/master@{#321199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -90 lines) Patch
M ash/shell.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.h View 2 chunks +8 lines, -11 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.cc View 3 chunks +25 lines, -36 lines 0 comments Download
M ui/base/user_activity/user_activity_detector_unittest.cc View 14 chunks +13 lines, -31 lines 0 comments Download
M ui/ozone/platform/test/ozone_platform_test.cc View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
afakhry
Created Revert of Fix for menus blocking user activity detection (Retry).
5 years, 9 months ago (2015-03-18 20:45:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016173002/1
5 years, 9 months ago (2015-03-18 20:45:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 20:46:53 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 20:47:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e505f2145d83f58988c17640db50c21639bb8c8
Cr-Commit-Position: refs/heads/master@{#321199}

Powered by Google App Engine
This is Rietveld 408576698