tools/metrics/histograms/histograms.xml - Issue 1016113002: Instrument "Remove this person" in user manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1016113002: Instrument "Remove this person" in user manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback/Naming tweaks Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 0cb8649f23eea05b2aed352551d059f8eaa5ab2b..0d7ae4e109bd3bb3d4e14d703cccb151e372a473 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -29073,10 +29073,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.

<owner>mlerman@chromium.org</owner>

+ <owner>anthonyvd@chromium.org</owner>

- This histogram tracks which UI screen was used to delete a profile. This

- does not track when the profile is actually deleted, which is an

- asycnhronous process that happens later.

+ This histogram tracks which UI screen was used to initiate and confirm the

+ deletion of a profile. This does not track when the profile is actually

+ deleted, which is an asynchronous process that happens later.

</summary>

</histogram>

@@ -56978,8 +56979,21 @@ To add a new entry, add it with any value and run test to compute valid value.

</enum>

- <int value="0" label="Settings Page"/>

- <int value="1" label="User Manager"/>

+ <int value="0" label="Settings Page">

+ The user confirmed deletion of a profile from the settings page.

+ </int>

+ <int value="1" label="User Manager">

+ The user confirmed deletion of a profile from the User Manager.

+ </int>

+ <int value="2" label="User Manager Warning Shown">

+ The user clicked 'Remove this person' in the user manager and was shown the

+ profile deletion warning. No profile deletion action has been started yet.

+ </int>

+ <int value="3" label="Settings Page Warning Shown">

+ The user clicked 'Remove...' or the 'X' in the settings page and was shown

+ the profile deletion warning. No profile deletion action has been started

+ yet.

+ </int>

</enum>