Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4240)

Unified Diff: chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

Issue 1016113002: Instrument "Remove this person" in user manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback/Naming tweaks Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
diff --git a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
index 186dd0e3fc9bae89beb4cf2ce527bfcb6605ff99..91693b1ac1aac7d9c3529b52ef7a41b96eb4d82b 100644
--- a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
+++ b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
@@ -75,6 +75,8 @@ const char kJsApiUserManagerLaunchGuest[] = "launchGuest";
const char kJsApiUserManagerLaunchUser[] = "launchUser";
const char kJsApiUserManagerRemoveUser[] = "removeUser";
const char kJsApiUserManagerAttemptUnlock[] = "attemptUnlock";
+const char kJsApiUserManagerLogRemoveUserWarningShown[] =
+ "logRemoveUserWarningShown";
const size_t kAvatarIconSize = 180;
@@ -534,6 +536,12 @@ void UserManagerScreenHandler::HandleHardlockUserPod(
HideUserPodCustomIcon(email);
}
+void UserManagerScreenHandler::HandleRemoveUserWarningShown(
Dan Beam 2015/03/19 17:28:39 nit: could also be in an anonymous namespace
Dan Beam 2015/03/19 17:28:39 nit: HandleLogRemoveUserWarningShown
+ const base::ListValue* args) {
+ ProfileMetrics::LogProfileDeleteUser(
+ ProfileMetrics::DELETE_PROFILE_USER_MANAGER_SHOW_WARNING);
+}
+
void UserManagerScreenHandler::OnClientLoginSuccess(
const ClientLoginResult& result) {
LocalAuth::SetLocalAuthCredentials(authenticating_profile_index_,
@@ -594,6 +602,9 @@ void UserManagerScreenHandler::RegisterMessages() {
web_ui()->RegisterMessageCallback(kJsApiUserManagerAttemptUnlock,
base::Bind(&UserManagerScreenHandler::HandleAttemptUnlock,
base::Unretained(this)));
+ web_ui()->RegisterMessageCallback(kJsApiUserManagerLogRemoveUserWarningShown,
+ base::Bind(&UserManagerScreenHandler::HandleRemoveUserWarningShown,
+ base::Unretained(this)));
const content::WebUI::MessageCallback& kDoNothingCallback =
base::Bind(&HandleAndDoNothing);

Powered by Google App Engine
This is Rietveld 408576698