Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1016023002: Move 'closePath' handling to the consumers (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move 'closePath' handling to the consumers Only one consumer which needs it: SVGPathBuilder; Move it there. BUG=467592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192163

Patch Set 1 #

Total comments: 2

Patch Set 2 : closePath() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M Source/core/svg/SVGPathBlender.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathBuilder.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathBuilder.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathByteStreamBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathByteStreamBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathConsumer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathParser.cpp View 4 chunks +2 lines, -6 lines 0 comments Download
M Source/core/svg/SVGPathSegListBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegListBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathStringBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathStringBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathTraversalStateBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathTraversalStateBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
fs
5 years, 9 months ago (2015-03-18 15:47:00 UTC) #2
pdr.
LGTM https://codereview.chromium.org/1016023002/diff/1/Source/core/svg/SVGPathBuilder.cpp File Source/core/svg/SVGPathBuilder.cpp (right): https://codereview.chromium.org/1016023002/diff/1/Source/core/svg/SVGPathBuilder.cpp#newcode35 Source/core/svg/SVGPathBuilder.cpp:35: m_path.closeSubpath(); Just call closePath() here?
5 years, 9 months ago (2015-03-18 19:31:08 UTC) #3
kouhei (in TOK)
lgtm
5 years, 9 months ago (2015-03-19 01:34:09 UTC) #4
fs
https://codereview.chromium.org/1016023002/diff/1/Source/core/svg/SVGPathBuilder.cpp File Source/core/svg/SVGPathBuilder.cpp (right): https://codereview.chromium.org/1016023002/diff/1/Source/core/svg/SVGPathBuilder.cpp#newcode35 Source/core/svg/SVGPathBuilder.cpp:35: m_path.closeSubpath(); On 2015/03/18 19:31:08, pdr wrote: > Just call ...
5 years, 9 months ago (2015-03-19 09:44:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016023002/20001
5 years, 9 months ago (2015-03-19 11:26:06 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:59:55 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192163

Powered by Google App Engine
This is Rietveld 408576698