Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Side by Side Diff: Source/core/svg/SVGPathBuilder.cpp

Issue 1016023002: Move 'closePath' handling to the consumers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGPathBuilder.h ('k') | Source/core/svg/SVGPathByteStreamBuilder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2002, 2003 The Karbon Developers 2 * Copyright (C) 2002, 2003 The Karbon Developers
3 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org> 3 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
4 * Copyright (C) 2006, 2007 Rob Buis <buis@kde.org> 4 * Copyright (C) 2006, 2007 Rob Buis <buis@kde.org>
5 * Copyright (C) 2007, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 10 matching lines...) Expand all
21 * Boston, MA 02110-1301, USA. 21 * Boston, MA 02110-1301, USA.
22 */ 22 */
23 23
24 #include "config.h" 24 #include "config.h"
25 #include "core/svg/SVGPathBuilder.h" 25 #include "core/svg/SVGPathBuilder.h"
26 26
27 #include "platform/graphics/Path.h" 27 #include "platform/graphics/Path.h"
28 28
29 namespace blink { 29 namespace blink {
30 30
31 void SVGPathBuilder::moveTo(const FloatPoint& targetPoint, bool closed, PathCoor dinateMode mode) 31 void SVGPathBuilder::moveTo(const FloatPoint& targetPoint, PathCoordinateMode mo de)
32 { 32 {
33 ASSERT(mode == AbsoluteCoordinates); 33 ASSERT(mode == AbsoluteCoordinates);
34 if (closed && !m_path.isEmpty()) 34 if (m_closed && !m_path.isEmpty())
35 m_path.closeSubpath(); 35 m_path.closeSubpath();
pdr. 2015/03/18 19:31:08 Just call closePath() here?
fs 2015/03/19 09:44:09 I suppose we could do that...
36 m_path.moveTo(targetPoint); 36 m_path.moveTo(targetPoint);
37 m_closed = false;
37 } 38 }
38 39
39 void SVGPathBuilder::lineTo(const FloatPoint& targetPoint, PathCoordinateMode mo de) 40 void SVGPathBuilder::lineTo(const FloatPoint& targetPoint, PathCoordinateMode mo de)
40 { 41 {
41 ASSERT(mode == AbsoluteCoordinates); 42 ASSERT(mode == AbsoluteCoordinates);
42 m_path.addLineTo(targetPoint); 43 m_path.addLineTo(targetPoint);
43 } 44 }
44 45
45 void SVGPathBuilder::curveToCubic(const FloatPoint& point1, const FloatPoint& po int2, const FloatPoint& targetPoint, PathCoordinateMode mode) 46 void SVGPathBuilder::curveToCubic(const FloatPoint& point1, const FloatPoint& po int2, const FloatPoint& targetPoint, PathCoordinateMode mode)
46 { 47 {
47 ASSERT(mode == AbsoluteCoordinates); 48 ASSERT(mode == AbsoluteCoordinates);
48 m_path.addBezierCurveTo(point1, point2, targetPoint); 49 m_path.addBezierCurveTo(point1, point2, targetPoint);
49 } 50 }
50 51
51 void SVGPathBuilder::closePath() 52 void SVGPathBuilder::closePath()
52 { 53 {
53 m_path.closeSubpath(); 54 m_path.closeSubpath();
55 m_closed = true;
54 } 56 }
55 57
56 } 58 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGPathBuilder.h ('k') | Source/core/svg/SVGPathByteStreamBuilder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698