Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 101583004: [gin] Turn gin into a component (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

[gin] Turn gin into a component This will allow for using gin from content and blink at the same time in a component build BUG=321631 R=abarth@chromium.org,aa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240425

Patch Set 1 #

Patch Set 2 : win #

Patch Set 3 : win #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -50 lines) Patch
M gin/arguments.h View 1 chunk +2 lines, -1 line 0 comments Download
M gin/array_buffer.h View 1 2 4 chunks +6 lines, -4 lines 1 comment Download
M gin/array_buffer.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M gin/converter.h View 14 chunks +20 lines, -18 lines 0 comments Download
M gin/dictionary.h View 3 chunks +3 lines, -2 lines 0 comments Download
M gin/function_template.h View 3 chunks +3 lines, -3 lines 0 comments Download
M gin/function_template.h.pump View 3 chunks +3 lines, -2 lines 0 comments Download
M gin/gin.gyp View 6 chunks +9 lines, -1 line 0 comments Download
A gin/gin_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
M gin/modules/console.h View 1 chunk +2 lines, -1 line 0 comments Download
M gin/modules/file_module_provider.h View 2 chunks +2 lines, -1 line 0 comments Download
M gin/modules/module_registry.h View 2 chunks +2 lines, -1 line 0 comments Download
M gin/modules/module_runner_delegate.h View 2 chunks +2 lines, -1 line 0 comments Download
M gin/object_template_builder.h View 3 chunks +3 lines, -2 lines 0 comments Download
M gin/per_context_data.h View 3 chunks +3 lines, -2 lines 0 comments Download
M gin/per_isolate_data.h View 2 chunks +2 lines, -1 line 0 comments Download
M gin/public/context_holder.h View 2 chunks +2 lines, -1 line 0 comments Download
M gin/public/isolate_holder.h View 2 chunks +2 lines, -1 line 0 comments Download
M gin/public/wrapper_info.h View 2 chunks +2 lines, -1 line 0 comments Download
M gin/runner.h View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M gin/try_catch.h View 1 chunk +2 lines, -1 line 0 comments Download
M gin/wrappable.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/mojo_apps.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
7 years ago (2013-12-12 13:29:35 UTC) #1
jochen (gone - plz use gerrit)
ptal
7 years ago (2013-12-12 15:56:09 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/101583004/diff/30001/gin/array_buffer.h File gin/array_buffer.h (right): https://codereview.chromium.org/101583004/diff/30001/gin/array_buffer.h#newcode32 gin/array_buffer.h:32: ArrayBuffer& operator=(const ArrayBuffer& other); We need to write ...
7 years ago (2013-12-12 16:41:45 UTC) #3
jochen (gone - plz use gerrit)
On 2013/12/12 16:41:45, abarth wrote: > lgtm > > https://codereview.chromium.org/101583004/diff/30001/gin/array_buffer.h > File gin/array_buffer.h (right): > ...
7 years ago (2013-12-12 16:55:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/101583004/30001
7 years ago (2013-12-12 16:56:31 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-12 21:32:39 UTC) #6
Message was sent while issue was closed.
Change committed as 240425

Powered by Google App Engine
This is Rietveld 408576698