Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: gin/function_template.h

Issue 101583004: [gin] Turn gin into a component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/function_template.h
diff --git a/gin/function_template.h b/gin/function_template.h
index 9db039dbacf2ed8121fe81f16cdcd6dd4ca65d17..14f6e78fe2fd7482e461dd7072ded9a31c77fe87 100644
--- a/gin/function_template.h
+++ b/gin/function_template.h
@@ -15,6 +15,7 @@
#include "base/logging.h"
#include "gin/arguments.h"
#include "gin/converter.h"
+#include "gin/gin_export.h"
#include "gin/handle.h"
#include "gin/public/gin_embedders.h"
#include "gin/public/wrapper_info.h"
@@ -58,10 +59,9 @@ struct CallbackParamTraits<const T*> {
// This simple base class is used so that we can share a single object template
// among every CallbackHolder instance.
-class CallbackHolderBase : public Wrappable<CallbackHolderBase> {
+class GIN_EXPORT CallbackHolderBase : public Wrappable<CallbackHolderBase> {
public:
static WrapperInfo kWrapperInfo;
-
protected:
virtual ~CallbackHolderBase() {}
};
@@ -333,7 +333,7 @@ struct Dispatcher<R(P1, P2, P3, P4)> {
// This should be called once per-isolate to initialize the function template
// system.
-void InitFunctionTemplates(PerIsolateData* isolate_data);
+GIN_EXPORT void InitFunctionTemplates(PerIsolateData* isolate_data);
// CreateFunctionTemplate creates a v8::FunctionTemplate that will create
« gin/array_buffer.h ('K') | « gin/dictionary.h ('k') | gin/function_template.h.pump » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698