sync/protocol/proto_value_conversions.h - Issue 101573003: Add the navigation redirect-chain to Sync sessions proto for offline analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/proto_value_conversions.h

Issue 101573003: Add the navigation redirect-chain to Sync sessions proto for offline analysis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android unit test (state_serializer_unittests.cc). Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl.cc ('K') | « content/public/common/page_transition_types.cc ('k') | sync/protocol/proto_value_conversions.cc » ('j') | sync/protocol/session_specifics.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/protocol/proto_value_conversions.h

diff --git a/sync/protocol/proto_value_conversions.h b/sync/protocol/proto_value_conversions.h

index 3c8f3d9511df94ed7a731b1d212281eca8c46b76..557294aaf4a7a0e86a90679eaf0ac9d7f94a8510 100644

--- a/sync/protocol/proto_value_conversions.h

+++ b/sync/protocol/proto_value_conversions.h

@@ -49,6 +49,7 @@ class Media;

class ManagedUserSettingSpecifics;

class ManagedUserSharedSettingSpecifics;

class ManagedUserSpecifics;

+class NavigationRedirect;

class NigoriSpecifics;

class PasswordSpecifics;

class PasswordSpecificsData;

@@ -116,6 +117,9 @@ SYNC_EXPORT_PRIVATE base::DictionaryValue* SessionWindowToValue(

SYNC_EXPORT_PRIVATE base::DictionaryValue* TabNavigationToValue(

const sync_pb::TabNavigation& tab_navigation);

+SYNC_EXPORT_PRIVATE base::DictionaryValue* NavigationRedirectToValue(

+ const sync_pb::NavigationRedirect& navigation_redirect);

// Sub-protocol of PasswordSpecifics.

SYNC_EXPORT_PRIVATE base::DictionaryValue* PasswordSpecificsDataToValue(