sync/protocol/proto_value_conversions.cc - Issue 101573003: Add the navigation redirect-chain to Sync sessions proto for offline analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 101573003: Add the navigation redirect-chain to Sync sessions proto for offline analysis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android unit test (state_serializer_unittests.cc). Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl.cc ('K') | « sync/protocol/proto_value_conversions.h ('k') | sync/protocol/session_specifics.proto » ('j') | sync/protocol/session_specifics.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/protocol/proto_value_conversions.cc

diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc

index be6394257c259167b7b037e035bb77d5af891277..7fe64045122492d3feeb14c46980ecfb50345204 100644

--- a/sync/protocol/proto_value_conversions.cc

+++ b/sync/protocol/proto_value_conversions.cc

@@ -203,6 +203,15 @@ base::DictionaryValue* TabNavigationToValue(

SET_STR_REP(content_pack_categories);

SET_INT32(http_status_code);

SET_INT32(referrer_policy);

+ SET_REP(navigation_redirect, NavigationRedirectToValue);

+ SET_STR(last_navigation_redirect_url);

+ return value;

+base::DictionaryValue* NavigationRedirectToValue(

+ const sync_pb::NavigationRedirect& proto) {

+ base::DictionaryValue* value = new base::DictionaryValue();

+ SET_STR(url);

return value;

}