Provide method for getting Isolate by v8::Message

Provide method for getting Isolate by v8::Message

v8::Message::GetIsolate will allow to avoid v8::Isolate::GetCurrent calls in Blink message listeners.

BUG=None
LOG=Y

[yurys, 2015-03-17 09:07:52]

yurys@chromium.org changed reviewers:
+ aandrey@chromium.org, dcarney@chromium.org, yangguo@chromium.org

[dcarney, 2015-03-17 09:14:05]

lgtm

[dcarney, 2015-03-17 09:16:02]

On 2015/03/17 09:14:05, dcarney wrote:
> lgtm

it would be preferred to pass the isolate in the messagecallback, would that be
okay?  if so, i'll prepare a cl to change the callback instead

[yurys, 2015-03-17 10:17:17]

On 2015/03/17 09:16:02, dcarney wrote:
> On 2015/03/17 09:14:05, dcarney wrote:
> > lgtm
> 
> it would be preferred to pass the isolate in the messagecallback, would that
be
> okay?  if so, i'll prepare a cl to change the callback instead

It would work either way, I don't have strong opinion on that. I'd rather
incorporate error object passed as a separate parameter to MessageCallback into
Message object and have MessageCallback accept single parameter. What's the
advantage of passing Isolate as a separate parameter?

[dcarney, 2015-03-17 10:25:25]

> It would work either way, I don't have strong opinion on that. I'd rather
> incorporate error object passed as a separate parameter to MessageCallback
into
> Message object and have MessageCallback accept single parameter. What's the
> advantage of passing Isolate as a separate parameter?

it's more consistent with the rest of the api.  we try to pass isolate as the
first parameter.  sometimes it's not worth the trouble to change the api.  since
i don't know how these callbacks are used in blink, i don't know how complicated
it would be

[yurys, 2015-03-17 10:30:12]

On 2015/03/17 10:25:25, dcarney wrote:
> > It would work either way, I don't have strong opinion on that. I'd rather
> > incorporate error object passed as a separate parameter to MessageCallback
> into
> > Message object and have MessageCallback accept single parameter. What's the
> > advantage of passing Isolate as a separate parameter?
> 
> it's more consistent with the rest of the api.  we try to pass isolate as the
> first parameter.  sometimes it's not worth the trouble to change the api. 
since
> i don't know how these callbacks are used in blink, i don't know how
complicated
> it would be

It should be fairly simple. The callbacks are added in V8Initializer.cpp, one
for worker isolate, another for main thread.

[dcarney, 2015-03-17 10:31:01]

On 2015/03/17 10:30:12, yurys wrote:
> On 2015/03/17 10:25:25, dcarney wrote:
> > > It would work either way, I don't have strong opinion on that. I'd rather
> > > incorporate error object passed as a separate parameter to MessageCallback
> > into
> > > Message object and have MessageCallback accept single parameter. What's
the
> > > advantage of passing Isolate as a separate parameter?
> > 
> > it's more consistent with the rest of the api.  we try to pass isolate as
the
> > first parameter.  sometimes it's not worth the trouble to change the api. 
> since
> > i don't know how these callbacks are used in blink, i don't know how
> complicated
> > it would be
> 
> It should be fairly simple. The callbacks are added in V8Initializer.cpp, one
> for worker isolate, another for main thread.

okay, i'll just convert them for consistency

[yurys, 2015-03-17 10:31:38]

On 2015/03/17 10:31:01, dcarney wrote:
> On 2015/03/17 10:30:12, yurys wrote:
> > On 2015/03/17 10:25:25, dcarney wrote:
> > > > It would work either way, I don't have strong opinion on that. I'd
rather
> > > > incorporate error object passed as a separate parameter to
MessageCallback
> > > into
> > > > Message object and have MessageCallback accept single parameter. What's
> the
> > > > advantage of passing Isolate as a separate parameter?
> > > 
> > > it's more consistent with the rest of the api.  we try to pass isolate as
> the
> > > first parameter.  sometimes it's not worth the trouble to change the api. 
> > since
> > > i don't know how these callbacks are used in blink, i don't know how
> > complicated
> > > it would be
> > 
> > It should be fairly simple. The callbacks are added in V8Initializer.cpp,
one
> > for worker isolate, another for main thread.
> 
> okay, i'll just convert them for consistency

Thanks. I'm closing this issue then.