Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 1015633004: Use Sk4x to speed-up bounds of an array of points (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use Sk4x to speed-up bounds of an array of points BUG=skia: Committed: https://skia.googlesource.com/skia/+/b25a83bd8802b7c3c5746c319e781f45337fe207

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M bench/ScalarBench.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkRect.cpp View 1 3 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
reed1
5 years, 9 months ago (2015-03-25 18:24:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015633004/1
5 years, 9 months ago (2015-03-25 18:24:19 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-25 18:24:19 UTC) #5
mtklein
lgtm https://codereview.chromium.org/1015633004/diff/1/src/core/SkRect.cpp File src/core/SkRect.cpp (right): https://codereview.chromium.org/1015633004/diff/1/src/core/SkRect.cpp#newcode110 src/core/SkRect.cpp:110: accum *= Sk4f(0); // See is_finite(). ? https://codereview.chromium.org/1015633004/diff/1/src/core/SkRect.cpp#newcode116 ...
5 years, 9 months ago (2015-03-25 18:35:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015633004/20001
5 years, 9 months ago (2015-03-25 21:24:59 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 21:30:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b25a83bd8802b7c3c5746c319e781f45337fe207

Powered by Google App Engine
This is Rietveld 408576698