chrome/chrome_tests_unit.gypi - Issue 1015363003: Move BinaryFeatureExtractor and PEImageReader to common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 1015363003: Move BinaryFeatureExtractor and PEImageReader to common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zip2

Patch Set: sync to position 321353 Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_tests_unit.gypi

diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi

index 3b2003689c94d0eb92dfb1828a4ee93ca8bb3921..36ae7e20e92276a3df33ba429a092d861751f323 100644

--- a/chrome/chrome_tests_unit.gypi

+++ b/chrome/chrome_tests_unit.gypi

@@ -1002,8 +1002,6 @@

'browser/notifications/platform_notification_service_unittest.cc',

'chrome_unit_tests_full_safe_browsing_sources': [

- 'browser/safe_browsing/binary_feature_extractor_unittest.cc',

- 'browser/safe_browsing/binary_feature_extractor_win_unittest.cc',

'browser/safe_browsing/browser_feature_extractor_unittest.cc',

'browser/safe_browsing/chunk_range_unittest.cc',

'browser/safe_browsing/client_side_detection_host_unittest.cc',

@@ -1035,7 +1033,6 @@

'browser/safe_browsing/local_two_phase_testserver.cc',

'browser/safe_browsing/malware_details_unittest.cc',

'browser/safe_browsing/path_sanitizer_unittest.cc',

- 'browser/safe_browsing/pe_image_reader_win_unittest.cc',

'browser/safe_browsing/ping_manager_unittest.cc',

'browser/safe_browsing/prefix_set_unittest.cc',

'browser/safe_browsing/protocol_manager_unittest.cc',

@@ -1046,8 +1043,11 @@

'browser/safe_browsing/safe_browsing_store_unittest.cc',

'browser/safe_browsing/safe_browsing_util_unittest.cc',

'browser/safe_browsing/two_phase_uploader_unittest.cc',

+ 'common/safe_browsing/binary_feature_extractor_unittest.cc',

+ 'common/safe_browsing/binary_feature_extractor_win_unittest.cc',

'common/safe_browsing/ipc_protobuf_message_test_messages.h',

'common/safe_browsing/ipc_protobuf_message_unittest.cc',

+ 'common/safe_browsing/pe_image_reader_win_unittest.cc',

'renderer/safe_browsing/features_unittest.cc',

'renderer/safe_browsing/murmurhash3_util_unittest.cc',

'renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc',

« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/safe_browsing/binary_feature_extractor.h » ('j') | no next file with comments »