Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1014793003: Feedback vector: ASAN found memory leaks during AST Numbering pass. (Closed)

Created:
5 years, 9 months ago by mvstanton
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Feedback vector: ASAN found memory leaks during AST Numbering pass. The cause was dynamic allocation of an accounting structure used to create/initialize the type feedback vector, done at the end of the numbering pass. The solution is to Zone-allocate the structure to bring it's lifetime in line with the compilation unit. BUG= Committed: https://crrev.com/7478c5a0cc4baccf30d83e01be8a8dc5cbe65900 Cr-Commit-Position: refs/heads/master@{#27241}

Patch Set 1 #

Patch Set 2 : Minor fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -42 lines) Patch
M src/ast.h View 4 chunks +5 lines, -4 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/type-feedback-vector.h View 3 chunks +33 lines, -6 lines 0 comments Download
M src/type-feedback-vector.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 5 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Yang, here is the CL we just discussed, thanks for the look, --Michael
5 years, 9 months ago (2015-03-17 13:43:52 UTC) #2
Yang
lgtm
5 years, 9 months ago (2015-03-17 14:05:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014793003/20001
5 years, 9 months ago (2015-03-17 14:20:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 15:16:27 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 15:16:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7478c5a0cc4baccf30d83e01be8a8dc5cbe65900
Cr-Commit-Position: refs/heads/master@{#27241}

Powered by Google App Engine
This is Rietveld 408576698