src/heap/heap.cc - Issue 1014793003: Feedback vector: ASAN found memory leaks during AST Numbering pass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1014793003: Feedback vector: ASAN found memory leaks during AST Numbering pass. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Minor fixes. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 6ce23da02908f33323bd8ce6a7b6b1ee4c7e319f..52066ea047e8a787691416086db3e90d58f89bff 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -3127,10 +3127,9 @@ void Heap::CreateInitialObjects() {

set_microtask_queue(empty_fixed_array());

if (FLAG_vector_ics) {

- FeedbackVectorSpec spec(0, 1);

- spec.SetKind(0, Code::KEYED_LOAD_IC);

+ FeedbackVectorSpec spec(0, Code::KEYED_LOAD_IC);

Handle<TypeFeedbackVector> dummy_vector =

- factory->NewTypeFeedbackVector(spec);

+ factory->NewTypeFeedbackVector(&spec);

dummy_vector->Set(FeedbackVectorICSlot(0),

*TypeFeedbackVector::MegamorphicSentinel(isolate()),

SKIP_WRITE_BARRIER);

« no previous file with comments | « src/factory.cc ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »