Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1014793002: List IDL compiler sources as inputs to GN's idl_impl action (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

List IDL compiler sources as inputs to GN's idl_impl action This simply copies the inputs of the similar idl_compiler action, and fixes a dependency issue where e.g. UnionTypes{Core,Modules}.* would not be regenerated properly when the compiler sources were modified. BUG=240176, 321462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M Source/bindings/scripts/scripts.gni View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Jens Widell
PTAL Spurious GN bot compilation issues observed here: https://codereview.chromium.org/1011093002/#ps20001
5 years, 9 months ago (2015-03-17 12:17:33 UTC) #2
vivekg
On 2015/03/17 12:17:33, Jens Widell wrote: > PTAL > > Spurious GN bot compilation issues ...
5 years, 9 months ago (2015-03-17 12:58:48 UTC) #3
Jens Widell
On 2015/03/17 12:58:48, vivekg_ wrote: > On 2015/03/17 12:17:33, Jens Widell wrote: > > PTAL ...
5 years, 9 months ago (2015-03-17 13:42:08 UTC) #4
vivekg
On 2015/03/17 at 13:42:08, jl wrote: > On 2015/03/17 12:58:48, vivekg_ wrote: > > On ...
5 years, 9 months ago (2015-03-17 14:18:58 UTC) #5
haraken
LGTM
5 years, 9 months ago (2015-03-17 15:03:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014793002/1
5 years, 9 months ago (2015-03-17 15:04:43 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 15:07:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192014

Powered by Google App Engine
This is Rietveld 408576698