Issue 402883003: Add some v8 bindings files to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402883003: Add some v8 bindings files to GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
haraken, jamesr

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Add some v8 bindings files to GN build. There were missing but we have never linked anything requiring this in GN. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178672

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -0 lines)			Patch
A	Source/bindings/modules/v8/custom/custom.gni	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	Source/bindings/modules/v8/custom/custom.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	Source/bindings/modules/v8/v8.gni	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	Source/bindings/modules/v8/v8.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/modules/BUILD.gn	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/402883003/1

6 years, 5 months ago (2014-07-22 16:40:32 UTC) #4

Message was sent while issue was closed.

Change committed as 178672