CpuProfiler: ia32. put right address to the stack, so the callee would be able to resolve it into t…

CpuProfiler: ia32. put right address to the stack, so the callee would be able to resolve it into the right deopt_info.

'from' is using for Code object lookup and will be used for
inline_id lookup. see https://codereview.chromium.org/1012633002
So we should be able to map it.

BUG=chromium:452067
LOG=n

Committed: https://crrev.com/bcf51d25aa5432778b69286f1720c1bf71fbf65d
Cr-Commit-Position: refs/heads/master@{#27252}

[loislo, 2015-03-17 09:28:41]

loislo@chromium.org changed reviewers:
+ alph@chromium.org, jarin@chromium.org, svenpanne@chromium.org

[loislo, 2015-03-17 09:28:42]

PTAL

[Jarin, 2015-03-17 12:44:22]

https://codereview.chromium.org/1014783002/diff/20001/src/ia32/lithium-codege...
File src/ia32/lithium-codegen-ia32.cc (right):

https://codereview.chromium.org/1014783002/diff/20001/src/ia32/lithium-codege...
src/ia32/lithium-codegen-ia32.cc:394:
Immediate(ExternalReference::ForDeoptEntry(entry)));
This will not work because an asynchronous signal handler can clobber the stack
below the top.

Why cannot you just push it here?

[loislo, 2015-03-17 14:48:39]

On 2015/03/17 at 12:44:22, jarin wrote:
>
https://codereview.chromium.org/1014783002/diff/20001/src/ia32/lithium-codege...
> File src/ia32/lithium-codegen-ia32.cc (right):
> 
>
https://codereview.chromium.org/1014783002/diff/20001/src/ia32/lithium-codege...
> src/ia32/lithium-codegen-ia32.cc:394:
Immediate(ExternalReference::ForDeoptEntry(entry)));
> This will not work because an asynchronous signal handler can clobber the
stack below the top.

Does Red Zone helps in this case?
http://en.wikipedia.org/wiki/Red_zone_(computing) 
> 
> Why cannot you just push it here?

[Sven Panne, 2015-03-17 14:54:09]

On 2015/03/17 14:48:39, loislo wrote:
> Does Red Zone helps in this case?
> http://en.wikipedia.org/wiki/Red_zone_(computing) 

IIRC, this is an ABI issue: Windows, Xen, HaLVM, and probably a few others don't
impose a mandatory red zone (at least not on x64). So why not simply push?

[loislo, 2015-03-17 15:52:24]

On 2015/03/17 at 14:54:09, svenpanne wrote:
> On 2015/03/17 14:48:39, loislo wrote:
> > Does Red Zone helps in this case?
> > http://en.wikipedia.org/wiki/Red_zone_(computing) 
> 
> IIRC, this is an ABI issue: Windows, Xen, HaLVM, and probably a few others
don't impose a mandatory red zone (at least not on x64). So why not simply push?

comments addressed

[alph, 2015-03-17 17:58:47]

lgtm

[Sven Panne, 2015-03-18 08:04:14]

lgtm

[loislo, 2015-03-18 08:07:06]

The CQ bit was checked by loislo@chromium.org

[loislo, 2015-03-18 08:07:07]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/1014783002/#ps80001
(title: "comments were added")

[commit-bot: I haz the power, 2015-03-18 08:07:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1014783002/80001

[commit-bot: I haz the power, 2015-03-18 08:09:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-18 08:09:52]

Patchset 5 (id:??) landed as
https://crrev.com/bcf51d25aa5432778b69286f1720c1bf71fbf65d
Cr-Commit-Position: refs/heads/master@{#27252}