Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1014763003: MIPS: Support INTERNAL_REFERENCE_ENCODED in serializer. (Closed)

Created:
5 years, 9 months ago by paul.l...
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Support INTERNAL_REFERENCE_ENCODED in serializer. Add mips support for the changes in https://codereview.chromium.org/1000373003. On mips, these support the long-branch mechanism. TEST=test-serialize/SerializeToplevelLargeCodeObject BUG= Committed: https://crrev.com/cd9b6ec224ba23c0b073ccd4a818d9942720db96 Cr-Commit-Position: refs/heads/master@{#27244}

Patch Set 1 #

Patch Set 2 : add mips64 port. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -8 lines) Patch
M src/mips/assembler-mips-inl.h View 1 chunk +32 lines, -4 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 1 chunk +40 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL. MIPS reviewers,I omitted support for MacroAssembler::J(Label* L, ...) as it appears to no longer ...
5 years, 9 months ago (2015-03-17 05:06:29 UTC) #2
dusmil.imgtec
LGTM, yes the J(Label*, ...) is not used for internal references that are part of ...
5 years, 9 months ago (2015-03-17 14:36:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014763003/20001
5 years, 9 months ago (2015-03-17 16:36:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 17:00:18 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 17:00:32 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd9b6ec224ba23c0b073ccd4a818d9942720db96
Cr-Commit-Position: refs/heads/master@{#27244}

Powered by Google App Engine
This is Rietveld 408576698