Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1000373003: Serializer: prepare support for INTERNAL_REFERENCE_ENCODED. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: prepare support for INTERNAL_REFERENCE_ENCODED. Platform ports that use this RelocInfo kind need to implement set_target_internal_reference accordingly to distinguish between INTERNAL_REFERENCE and INTERNAL_REFERENCE_ENCODED. R=svenpanne@chromium.org Committed: https://crrev.com/a873c9f33669e657f0b8ae9270a9f2553e1996d0 Cr-Commit-Position: refs/heads/master@{#27177}

Patch Set 1 #

Patch Set 2 : internal reference enum #

Patch Set 3 : #

Patch Set 4 : switch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M src/assembler.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M src/assembler.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M src/serialize.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Yang
5 years, 9 months ago (2015-03-13 08:31:55 UTC) #1
Sven Panne
lgtm
5 years, 9 months ago (2015-03-13 08:49:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000373003/1
5 years, 9 months ago (2015-03-13 08:50:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/3760)
5 years, 9 months ago (2015-03-13 08:52:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000373003/20001
5 years, 9 months ago (2015-03-13 09:32:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000373003/60001
5 years, 9 months ago (2015-03-13 10:06:51 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-13 10:08:02 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 10:08:12 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a873c9f33669e657f0b8ae9270a9f2553e1996d0
Cr-Commit-Position: refs/heads/master@{#27177}

Powered by Google App Engine
This is Rietveld 408576698