Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1014643002: [renderer]: Fix RendererScheduler shutdown logic to ensure it is shutdown before the MessageLoop. (Closed)

Created:
5 years, 9 months ago by rmcilroy
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[renderer]: Fix RendererScheduler shutdown logic to ensure it is shutdown before the MessageLoop. The RendererScheduler needs to be shutdown before the MessageLoop. Previously this was the case as blink was shutdown before the message loop, however now the message loop is shutdown first. This CL ensures that the renderer scheduler is shutdown just before the message loop. BUG=467369 Committed: https://crrev.com/168f3dccd82fc0274ac3f573f1607d23b3fe8181 Cr-Commit-Position: refs/heads/master@{#320908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M content/renderer/render_thread_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/scheduler/web_scheduler_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rmcilroy
jochen@chromium.org: Please review changes in renderer_main.cc skyostil@chromium.org: Please review changes in web_scheduler_impl.cc Blink side of ...
5 years, 9 months ago (2015-03-16 18:23:39 UTC) #2
Sami
Thanks, lgtm % trybots passing :)
5 years, 9 months ago (2015-03-16 19:10:21 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-17 10:30:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014643002/1
5 years, 9 months ago (2015-03-17 10:47:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 13:09:21 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 13:15:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/168f3dccd82fc0274ac3f573f1607d23b3fe8181
Cr-Commit-Position: refs/heads/master@{#320908}

Powered by Google App Engine
This is Rietveld 408576698