Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1011693003: Remove WebScheduler::shutdown() which is no longer needed. (Closed)

Created:
5 years, 9 months ago by rmcilroy
Modified:
5 years, 9 months ago
CC:
blink-reviews, dglazkov+blink, scheduler-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove WebScheduler::shutdown() which is no longer needed. The scheduler is now shutdown as part of the renderer_main shutdown sequence before Blink is shutdown, so remove the shutdown method. BUG=467369 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192047

Patch Set 1 #

Patch Set 2 : Fix SchedulerTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M Source/platform/scheduler/Scheduler.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/scheduler/SchedulerTest.cpp View 1 4 chunks +0 lines, -19 lines 0 comments Download
M public/platform/WebScheduler.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
rmcilroy
Jochen: PTAL, thanks. Sami: FYI and comments welcome.
5 years, 9 months ago (2015-03-16 18:25:18 UTC) #2
Sami
lgtm.
5 years, 9 months ago (2015-03-16 19:11:15 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-17 10:31:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011693003/1
5 years, 9 months ago (2015-03-17 13:31:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/31720)
5 years, 9 months ago (2015-03-17 13:50:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011693003/20001
5 years, 9 months ago (2015-03-17 21:54:02 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 23:36:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192047

Powered by Google App Engine
This is Rietveld 408576698