Issue 1014553003: Revert "Indexed PNG decoding: Ensure color table is large enough that the bit depth of the image wi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1014553003: Revert "Indexed PNG decoding: Ensure color table is large enough that the bit depth of the image wi… (Closed)

Created:
5 years, 9 months ago by scroggo

Modified:
5 years, 9 months ago

Reviewers:
egdaniel, David Lattimore

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert "Indexed PNG decoding: Ensure color table is large enough that the bit depth of the image will not allow reads beyond its end." This reverts commit 493c1ce1cd406ef28683203146274154783452ce. NOTRY=true NOTREECHECKS=true TBR=egdaniel@google.com,dml@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/cdeca446197329de91d87d12ad689d03d7e4d261

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -63 lines)			Patch
M	gyp/tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/images/SkImageDecoder_libpng.cpp	View	6 chunks	+14 lines, -18 lines	0 comments	Download
D	tests/IndexedPngOverflowTest.cpp	View	1 chunk	+0 lines, -44 lines	0 comments	Download

Total messages: 3 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014553003/1

5 years, 9 months ago (2015-03-17 12:25:47 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-17 12:26:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cdeca446197329de91d87d12ad689d03d7e4d261