Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2173)

Unified Diff: content/public/renderer/content_renderer_client.h

Issue 1014543003: Add an IPC method for Blink to call RapporService::RecordSample() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix all review comments, ran "git cl format" Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/content_renderer_client.h
diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h
index ca4d51db881f8d8310f9e2fac5d4ce8c79d77974..64facecc10788890be0e653c1063f19b94fa7df9 100644
--- a/content/public/renderer/content_renderer_client.h
+++ b/content/public/renderer/content_renderer_client.h
@@ -291,6 +291,12 @@ class CONTENT_EXPORT ContentRendererClient {
// Returns a user agent override specific for |url|, or empty string if
// default user agent should be used.
virtual std::string GetUserAgentOverrideForURL(const GURL& url);
+
+ // Record a sample string to a Rappor metric.
Alexei Svitkine (slow) 2015/04/08 14:57:11 Nit: Use a consistent tense with the other comment
kojii 2015/04/08 17:31:46 Done.
+ virtual void RecordRappor(const std::string& metric,
+ const std::string& sample) {}
Alexei Svitkine (slow) 2015/04/08 14:57:11 Nit: Add a blank line under this, since these have
kojii 2015/04/08 17:31:46 Done.
+ // Record a domain and registry of a url to a Rappor metric.
Alexei Svitkine (slow) 2015/04/08 14:57:11 I'm slightly worried that someone (who's not a pro
kojii 2015/04/08 17:31:46 Done.
Alexei Svitkine (slow) 2015/04/08 17:53:50 My suggestion was to also include "See: https://ww
+ virtual void RecordRapporURL(const std::string& metric, const GURL& url) {}
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698