Add an IPC method for Blink to call RapporService::RecordSample()

content/public/renderer/content_renderer_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 #define CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 273 matching lines @@
 
   // Returns true if the page at |url| can use Pepper Compositor APIs.
   virtual bool IsPluginAllowedToUseCompositorAPI(const GURL& url);
 
   // Returns true if dev channel APIs are available for plugins.
   virtual bool IsPluginAllowedToUseDevChannelAPIs();
 
   // Returns a user agent override specific for |url|, or empty string if
   // default user agent should be used.
   virtual std::string GetUserAgentOverrideForURL(const GURL& url);
+
+  // Record a sample string to a Rappor metric.

[Alexei Svitkine (slow), 2015/04/08 14:57:11]

Nit: Use a consistent tense with the other comments here. (i.e. Record ->
Records).

[kojii, 2015/04/08 17:31:46]

Done.

+  virtual void RecordRappor(const std::string& metric,
+                            const std::string& sample) {}

[Alexei Svitkine (slow), 2015/04/08 14:57:11]

Nit: Add a blank line under this, since these have comments.

[kojii, 2015/04/08 17:31:46]

Done.

+  // Record a domain and registry of a url to a Rappor metric.

[Alexei Svitkine (slow), 2015/04/08 14:57:11]

I'm slightly worried that someone (who's not a project member) reading this code
and not knowing what Rappor is may get the wrong impression that Chrome is
logging URLs.

How about changing both of these to: "... Rappor privacy-preserving metric. See:
https://www.chromium.org/developers/design-documents/rappor".

[kojii, 2015/04/08 17:31:46]

Done.

[Alexei Svitkine (slow), 2015/04/08 17:53:50]

My suggestion was to also include "See:
https://www.chromium.org/developers/design-documents/rappor" in the comments.

+  virtual void RecordRapporURL(const std::string& metric, const GURL& url) {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_