 Chromium Code Reviews
 Chromium Code Reviews Issue 1014503003:
  Hook up over approximating the weak closure to the idle time handler  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 1014503003:
  Hook up over approximating the weak closure to the idle time handler  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| Index: src/heap/gc-idle-time-handler.cc | 
| diff --git a/src/heap/gc-idle-time-handler.cc b/src/heap/gc-idle-time-handler.cc | 
| index ff2a559dd539dae2dc3ce3b1c09477243ba6f704..d10e1f65fe51e1a6094e2f8a583dc0a5cff7cf5f 100644 | 
| --- a/src/heap/gc-idle-time-handler.cc | 
| +++ b/src/heap/gc-idle-time-handler.cc | 
| @@ -16,6 +16,7 @@ const size_t GCIdleTimeHandler::kMinTimeForFinalizeSweeping = 100; | 
| const int GCIdleTimeHandler::kMaxMarkCompactsInIdleRound = 7; | 
| const int GCIdleTimeHandler::kIdleScavengeThreshold = 5; | 
| const double GCIdleTimeHandler::kHighContextDisposalRate = 100; | 
| +const size_t GCIdleTimeHandler::kMinTimeForOverApproximatingWeakClosureInMs = 1; | 
| void GCIdleTimeAction::Print() { | 
| @@ -176,6 +177,12 @@ bool GCIdleTimeHandler::ShouldDoFinalIncrementalMarkCompact( | 
| } | 
| +bool GCIdleTimeHandler::ShouldDoOverApproximateWeakClosure( | 
| + size_t idle_time_in_ms) { | 
| + return idle_time_in_ms >= kMinTimeForOverApproximatingWeakClosureInMs; | 
| 
Hannes Payer (out of office)
2015/03/16 12:35:15
Is that also true for slow devices?
 
jochen (gone - plz use gerrit)
2015/03/16 13:59:30
no idea. I added a TODO and will run some tests lo
 | 
| +} | 
| + | 
| + | 
| // The following logic is implemented by the controller: | 
| // (1) If we don't have any idle time, do nothing, unless a context was | 
| // disposed, incremental marking is stopped, and the heap is small. Then do |