Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1014503003: Hook up over approximating the weak closure to the idle time handler (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Hook up over approximating the weak closure to the idle time handler The feature itself is still behind a flag. BUG=v8:3862 R=hpayer@chromium.org LOG=n Committed: https://crrev.com/dde730ff50de57d7189f33da73840671d0aad748 Cr-Commit-Position: refs/heads/master@{#27225}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 4

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -12 lines) Patch
M src/heap/gc-idle-time-handler.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 1 chunk +13 lines, -5 lines 0 comments Download
M src/heap/incremental-marking.h View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-16 11:03:44 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/1014503003/diff/40001/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/1014503003/diff/40001/src/heap/gc-idle-time-handler.cc#newcode182 src/heap/gc-idle-time-handler.cc:182: return idle_time_in_ms >= kMinTimeForOverApproximatingWeakClosureInMs; Is that also true for ...
5 years, 9 months ago (2015-03-16 12:35:16 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1014503003/diff/40001/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/1014503003/diff/40001/src/heap/gc-idle-time-handler.cc#newcode182 src/heap/gc-idle-time-handler.cc:182: return idle_time_in_ms >= kMinTimeForOverApproximatingWeakClosureInMs; On 2015/03/16 at 12:35:15, Hannes ...
5 years, 9 months ago (2015-03-16 13:59:31 UTC) #3
Hannes Payer (out of office)
lgtm
5 years, 9 months ago (2015-03-16 14:43:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014503003/60001
5 years, 9 months ago (2015-03-16 14:46:49 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-16 14:51:14 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 14:51:21 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/dde730ff50de57d7189f33da73840671d0aad748
Cr-Commit-Position: refs/heads/master@{#27225}

Powered by Google App Engine
This is Rietveld 408576698