Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1014353002: [Telemetry] Remove CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions (Closed)

Created:
5 years, 9 months ago by nednguyen
Modified:
5 years, 9 months ago
Reviewers:
eakuefner, sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions as crbug.com/418375 is fixed. BUG=418375 Committed: https://crrev.com/4e937c22de66a201f310dbcdbb1f89a44750a875 Cr-Commit-Position: refs/heads/master@{#321156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py View 2 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
nednguyen
5 years, 9 months ago (2015-03-18 15:17:54 UTC) #2
eakuefner
lgtm
5 years, 9 months ago (2015-03-18 15:38:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014353002/1
5 years, 9 months ago (2015-03-18 15:46:03 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-18 15:46:05 UTC) #7
sullivan
lgtm
5 years, 9 months ago (2015-03-18 16:18:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014353002/1
5 years, 9 months ago (2015-03-18 16:18:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 17:16:40 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 17:17:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e937c22de66a201f310dbcdbb1f89a44750a875
Cr-Commit-Position: refs/heads/master@{#321156}

Powered by Google App Engine
This is Rietveld 408576698