Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

Issue 1014353002: [Telemetry] Remove CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
diff --git a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
index 16366bbce80428409efa1e5caa45e79e9af5f304..517bf58b751cecfe7f720a497770a4fa48efea71 100644
--- a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
+++ b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
@@ -61,30 +61,6 @@ class PageSetSmokeTest(unittest.TestCase):
for page in page_set.pages:
self.CheckAttributesOfPageBasicAttributes(page)
- def CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions(
- self, page_set):
- # This test is to make sure that page has been converted to use single
- # RunPageInteractions does not contain legacy run method.
- # For more context see: crbug.com/418375
- # TODO(nednguyen, ernstm): remove this test when crbug.com/418375 is marked
- # fixed.
- LEGACY_RUN_METHODS = [
- 'RunMediaMetrics',
- 'RunNoOp',
- 'RunRepaint',
- 'RunPrepareForScreenShot',
- 'RunSmoothness',
- 'RunWebrtc'
- ]
- for page in page_set.pages:
- if hasattr(page, 'RunPageInteractions'):
- for legacy_run_method in LEGACY_RUN_METHODS:
- self.assertTrue(
- not hasattr(page, legacy_run_method),
- msg=('page %s in page_set %s has both legacy Run.. methods and '
- 'RunPageInteractions defined. ' % (
- page, page_set.file_path)))
-
def CheckAttributesOfPageSetBasicAttributes(self, page_set):
if page_set.base_dir is not None:
self.assertTrue(
@@ -149,4 +125,3 @@ class PageSetSmokeTest(unittest.TestCase):
self.CheckArchive(page_set)
self.CheckCredentials(page_set)
self.CheckAttributes(page_set)
- self.CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions(page_set)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698