Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1014023003: Simplify SVGPathBlender::blendArcToSegment (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Simplify SVGPathBlender::blendArcToSegment By factoring the "simple" (same coordinate type) case out of SVGPathBlender::blendAnimatedFloatPoint, we can simplify the blending of rx/ry/angle of two arc segments. Additionally, since the m_fromMode == m_toMode if m_addTypesCount != 0, the same expression can be used to determine the mode of the blended segment. BUG=467592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M Source/core/svg/SVGPathBlender.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGPathBlender.cpp View 2 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
fs
5 years, 9 months ago (2015-03-17 16:38:13 UTC) #2
kouhei (in TOK)
lgtm
5 years, 9 months ago (2015-03-18 01:39:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014023003/1
5 years, 9 months ago (2015-03-18 09:08:50 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 09:11:37 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192073

Powered by Google App Engine
This is Rietveld 408576698