Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Issue 1013973004: Allow to create read only testing volumes. (Closed)

Created:
5 years, 9 months ago by mtomasz
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow to create read only testing volumes. TEST=Not used yet, but used in an upcoming CL. BUG=440674 Committed: https://crrev.com/c92662526e8457e4e725ecbe1df29f475e917bab Cr-Commit-Position: refs/heads/master@{#320877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@hirono: PTAL. Thanks.
5 years, 9 months ago (2015-03-17 06:37:48 UTC) #2
hirono
lgtm!
5 years, 9 months ago (2015-03-17 06:49:45 UTC) #3
mtomasz
Thanks!
5 years, 9 months ago (2015-03-17 06:50:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013973004/1
5 years, 9 months ago (2015-03-17 06:50:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 07:03:39 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 07:04:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c92662526e8457e4e725ecbe1df29f475e917bab
Cr-Commit-Position: refs/heads/master@{#320877}

Powered by Google App Engine
This is Rietveld 408576698