chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc - Issue 1013973004: Allow to create read only testing volumes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

Issue 1013973004: Allow to create read only testing volumes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc ('k') | chrome/browser/chromeos/file_manager/file_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

diff --git a/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc b/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

index 1eab05a8e329609fad484f62a2ff8b9fdc3b8597..29dd8ceeac8c3d618a7f10d83be19a8902282e4e 100644

--- a/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

+++ b/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

@@ -452,8 +452,10 @@ class LocalFileSystemExtensionApiTest : public FileSystemExtensionApiTestBase {

storage::kFileSystemTypeNativeLocal,

storage::FileSystemMountOption(),

mount_point_dir_));

- VolumeManager::Get(browser()->profile())->AddVolumeInfoForTesting(

- mount_point_dir_, VOLUME_TYPE_TESTING, chromeos::DEVICE_TYPE_UNKNOWN);

+ VolumeManager::Get(browser()->profile())

+ ->AddVolumeInfoForTesting(mount_point_dir_, VOLUME_TYPE_TESTING,

+ chromeos::DEVICE_TYPE_UNKNOWN,

+ false /* read_only */);

}

private:

@@ -483,8 +485,10 @@ class RestrictedFileSystemExtensionApiTest

storage::kFileSystemTypeRestrictedNativeLocal,

storage::FileSystemMountOption(),

mount_point_dir_));

- VolumeManager::Get(browser()->profile())->AddVolumeInfoForTesting(

- mount_point_dir_, VOLUME_TYPE_TESTING, chromeos::DEVICE_TYPE_UNKNOWN);

+ VolumeManager::Get(browser()->profile())

+ ->AddVolumeInfoForTesting(mount_point_dir_, VOLUME_TYPE_TESTING,

+ chromeos::DEVICE_TYPE_UNKNOWN,

+ false /* read_only */);

}

private:

@@ -683,9 +687,9 @@ class LocalAndDriveFileSystemExtensionApiTest

storage::FileSystemMountOption(),

local_mount_point_dir_));

VolumeManager::Get(browser()->profile())

- ->AddVolumeInfoForTesting(local_mount_point_dir_,

- VOLUME_TYPE_TESTING,

- chromeos::DEVICE_TYPE_UNKNOWN);

+ ->AddVolumeInfoForTesting(local_mount_point_dir_, VOLUME_TYPE_TESTING,

+ chromeos::DEVICE_TYPE_UNKNOWN,

+ false /* read_only */);

test_util::WaitUntilDriveMountPointIsAdded(browser()->profile());

}