Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1013843002: favor DCHECK_CURRENTLY_ON for better logs in android_webview/ (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
Torne
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in android_webview/ BUG=466848 Committed: https://crrev.com/f498ecffb43a051950422d258ad95b0b53f555d5 Cr-Commit-Position: refs/heads/master@{#321125}

Patch Set 1 #

Patch Set 2 : change a few more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -120 lines) Patch
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_contents_client_bridge_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_form_database_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_login_delegate.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M android_webview/browser/aw_request_interceptor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_resource_context.cc View 1 4 chunks +6 lines, -4 lines 0 comments Download
M android_webview/browser/icon_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/net/aw_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M android_webview/browser/renderer_host/print_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_contents.cc View 43 chunks +56 lines, -56 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M android_webview/native/aw_http_auth_handler.cc View 1 6 chunks +6 lines, -5 lines 0 comments Download
M android_webview/native/aw_pdf_exporter.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_quota_manager_bridge_impl.cc View 14 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@Torne: PTAL.
5 years, 9 months ago (2015-03-16 23:15:31 UTC) #2
Torne
Thanks Mostyn! LGTM. I've sent a PSA to the webview team to let them know ...
5 years, 9 months ago (2015-03-18 13:50:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013843002/20001
5 years, 9 months ago (2015-03-18 13:53:07 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 14:17:32 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 14:18:31 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f498ecffb43a051950422d258ad95b0b53f555d5
Cr-Commit-Position: refs/heads/master@{#321125}

Powered by Google App Engine
This is Rietveld 408576698