android_webview/browser/renderer_host/print_manager.cc - Issue 1013843002: favor DCHECK_CURRENTLY_ON for better logs in android_webview/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/renderer_host/print_manager.cc

Issue 1013843002: favor DCHECK_CURRENTLY_ON for better logs in android_webview/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change a few more Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc ('k') | android_webview/native/aw_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/renderer_host/print_manager.cc

diff --git a/android_webview/browser/renderer_host/print_manager.cc b/android_webview/browser/renderer_host/print_manager.cc

index ba29619b17b6014526a92b9ddd9d9e2967b69618..56a96f080574c858d2965e75294a8b1c74a43228 100644

--- a/android_webview/browser/renderer_host/print_manager.cc

+++ b/android_webview/browser/renderer_host/print_manager.cc

@@ -91,7 +91,7 @@ void PrintManager::OnDidGetDocumentCookie(int cookie) {

void PrintManager::OnGetDefaultPrintSettings(IPC::Message* reply_msg) {

// Unlike the printing_message_filter, we do process this in ui thread

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

OnGetDefaultPrintSettingsReply(reply_msg);

}

@@ -142,7 +142,7 @@ void PrintManager::OnPrintingFailed(int cookie) {

}

bool PrintManager::PrintNow() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (printing_)

return false;