Issue 101383006: Fix glitch that allows both "Loading..." and "[x] Save details in Chrome" to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101383006: Fix glitch that allows both "Loading..." and "[x] Save details in Chrome" to (Closed)

Created:
6 years, 11 months ago by Dan Beam

Modified:
6 years, 11 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix glitch that allows both "Loading..." and "[x] Save details in Chrome" to show at the same time when clicking "Use Google Wallet". BUG=331935 R=estade@chromium.org TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243380

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/views/autofill/autofill_dialog_views.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/101383006/1

6 years, 11 months ago (2014-01-07 00:07:22 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests, browser_tests_swarm, nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242174

6 years, 11 months ago (2014-01-07 10:07:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/101383006/1

6 years, 11 months ago (2014-01-07 17:22:16 UTC) #5

Message was sent while issue was closed.

Change committed as 243380

Expand Messages | Collapse Messages