base: Mark MessageLoop::Post*Task API deprecated

base/message_loop/message_loop.cc

Index: base/message_loop/message_loop.cc
diff --git a/base/message_loop/message_loop.cc b/base/message_loop/message_loop.cc
index daa7782e5216879b577a33c0b35f602bf369db5d..7e2e821b32f4ce3c910d32234396a89e65c8f0c8 100644
--- a/base/message_loop/message_loop.cc
+++ b/base/message_loop/message_loop.cc
@@ -276,7 +276,7 @@ void MessageLoop::PostTask(
     const tracked_objects::Location& from_here,
     const Closure& task) {
   DCHECK(!task.is_null()) << from_here.ToString();

[Wez, 2015/03/20 04:13:01]

These DCHECKs should be in the TaskRunner impl now, not in these boilerplate
methods.

[Sami, 2015/03/20 17:16:56]

Good point, done. (I checked that the same DCHECKs exist there.)

-  incoming_task_queue_->AddToIncomingQueue(from_here, task, TimeDelta(), true);
+  task_runner()->PostTask(from_here, task);

[danakj, 2015/03/19 21:43:20]

Note: This changes these into virtual function calls. I hope that won't be bad
for perf reasons.

[Sami, 2015/03/20 17:16:56]

Good point. I checked this by hacking TaskPerfTest to call into the MessageLoop
on a Nexus 6 and found a 15% regression (http://pastebin.com/4WRhBPJA). However,
turns out that was because calling task_runner() causes refptr churn. After I
changed this to access message_loop_proxy_ directly the regression went away.

(BTW, I decided not to land the TaskPerfTest changes since we're about to
deprecate this interface.)

 }
 
 void MessageLoop::PostDelayedTask(
@@ -284,14 +284,14 @@ void MessageLoop::PostDelayedTask(
     const Closure& task,
     TimeDelta delay) {
   DCHECK(!task.is_null()) << from_here.ToString();
-  incoming_task_queue_->AddToIncomingQueue(from_here, task, delay, true);
+  task_runner()->PostDelayedTask(from_here, task, delay);
 }
 
 void MessageLoop::PostNonNestableTask(
     const tracked_objects::Location& from_here,
     const Closure& task) {
   DCHECK(!task.is_null()) << from_here.ToString();
-  incoming_task_queue_->AddToIncomingQueue(from_here, task, TimeDelta(), false);
+  task_runner()->PostNonNestableTask(from_here, task);
 }
 
 void MessageLoop::PostNonNestableDelayedTask(
@@ -299,7 +299,7 @@ void MessageLoop::PostNonNestableDelayedTask(
     const Closure& task,
     TimeDelta delay) {
   DCHECK(!task.is_null()) << from_here.ToString();
-  incoming_task_queue_->AddToIncomingQueue(from_here, task, delay, false);
+  task_runner()->PostNonNestableDelayedTask(from_here, task, delay);
 }
 
 void MessageLoop::Run() {