base: Mark MessageLoop::Post*Task API deprecated

base/message_loop/message_loop.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop/message_loop.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 257 matching lines @@
 
 void MessageLoop::RemoveDestructionObserver(
     DestructionObserver* destruction_observer) {
   DCHECK_EQ(this, current());
   destruction_observers_.RemoveObserver(destruction_observer);
 }
 
 void MessageLoop::PostTask(
     const tracked_objects::Location& from_here,
     const Closure& task) {
   DCHECK(!task.is_null()) << from_here.ToString();

[Wez, 2015/03/20 04:13:01]

These DCHECKs should be in the TaskRunner impl now, not in these boilerplate
methods.

[Sami, 2015/03/20 17:16:56]

Good point, done. (I checked that the same DCHECKs exist there.)

-  incoming_task_queue_->AddToIncomingQueue(from_here, task, TimeDelta(), true);
+  task_runner()->PostTask(from_here, task);

[danakj, 2015/03/19 21:43:20]

Note: This changes these into virtual function calls. I hope that won't be bad
for perf reasons.

[Sami, 2015/03/20 17:16:56]

Good point. I checked this by hacking TaskPerfTest to call into the MessageLoop
on a Nexus 6 and found a 15% regression (http://pastebin.com/4WRhBPJA). However,
turns out that was because calling task_runner() causes refptr churn. After I
changed this to access message_loop_proxy_ directly the regression went away.

(BTW, I decided not to land the TaskPerfTest changes since we're about to
deprecate this interface.)

 }
 
 void MessageLoop::PostDelayedTask(
     const tracked_objects::Location& from_here,
     const Closure& task,
     TimeDelta delay) {
   DCHECK(!task.is_null()) << from_here.ToString();
-  incoming_task_queue_->AddToIncomingQueue(from_here, task, delay, true);
+  task_runner()->PostDelayedTask(from_here, task, delay);
 }
 
 void MessageLoop::PostNonNestableTask(
     const tracked_objects::Location& from_here,
     const Closure& task) {
   DCHECK(!task.is_null()) << from_here.ToString();
-  incoming_task_queue_->AddToIncomingQueue(from_here, task, TimeDelta(), false);
+  task_runner()->PostNonNestableTask(from_here, task);
 }
 
 void MessageLoop::PostNonNestableDelayedTask(
     const tracked_objects::Location& from_here,
     const Closure& task,
     TimeDelta delay) {
   DCHECK(!task.is_null()) << from_here.ToString();
-  incoming_task_queue_->AddToIncomingQueue(from_here, task, delay, false);
+  task_runner()->PostNonNestableDelayedTask(from_here, task, delay);
 }
 
 void MessageLoop::Run() {
   RunLoop run_loop;
   run_loop.Run();
 }
 
 void MessageLoop::RunUntilIdle() {
   RunLoop run_loop;
   run_loop.RunUntilIdle();
@@ skipping 402 matching lines @@
       persistent,
       mode,
       controller,
       delegate);
 }
 #endif
 
 #endif  // !defined(OS_NACL_SFI)
 
 }  // namespace base