Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1013753007: CpuProfiler: collect deopt pc offset for further usage in the inlined functions stack resolver. (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, alph, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: collect deopt pc offset for further usage in the inlined functions stack resolver. this is a fourth part of https://codereview.chromium.org/1012633002 In another patch I'll collect the inlining tree in cpu-profiler CodeEntry Each leaf for an inlined function will have a list of deopts and their pc offsets. So when deopt happens I'll be able to map the deopt pc_offset into inlined function id and point the web developer to the exact place where deopt has happened even if it was in the inlined function. BUG=chromium:452067 LOG=n Committed: https://crrev.com/33514ec25d910317d2ba7e1491b5e7e62cefb963 Cr-Commit-Position: refs/heads/master@{#27247}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/cpu-profiler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cpu-profiler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cpu-profiler-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.h View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
loislo
PTAL
5 years, 9 months ago (2015-03-17 10:15:50 UTC) #2
yurys
lgtm
5 years, 9 months ago (2015-03-17 10:36:58 UTC) #3
loislo
ptal
5 years, 9 months ago (2015-03-17 10:39:54 UTC) #5
Sven Panne
LGTM with a comment https://codereview.chromium.org/1013753007/diff/1/src/cpu-profiler.h File src/cpu-profiler.h (right): https://codereview.chromium.org/1013753007/diff/1/src/cpu-profiler.h#newcode83 src/cpu-profiler.h:83: int pc_offset; I would recommend ...
5 years, 9 months ago (2015-03-17 15:24:05 UTC) #6
loislo
comments addressed https://codereview.chromium.org/1013753007/diff/1/src/cpu-profiler.h File src/cpu-profiler.h (right): https://codereview.chromium.org/1013753007/diff/1/src/cpu-profiler.h#newcode83 src/cpu-profiler.h:83: int pc_offset; On 2015/03/17 at 15:24:05, Sven ...
5 years, 9 months ago (2015-03-17 17:36:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013753007/20001
5 years, 9 months ago (2015-03-17 17:37:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 18:50:06 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 18:50:18 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33514ec25d910317d2ba7e1491b5e7e62cefb963
Cr-Commit-Position: refs/heads/master@{#27247}

Powered by Google App Engine
This is Rietveld 408576698