Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1013713003: Ignore lint error RtlHardcoded for AwZoomControls (Closed)

Created:
5 years, 9 months ago by wajahat
Modified:
5 years, 9 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore lint error RtlHardcoded for AwZoomControls The following lint error is reported while building android_webview_apk can be ignored: AwZoomControls.java:76 Use "`Gravity.END`" instead of "`Gravity.RIGHT`" to ensure correct behavior in right-to-left locales: RtlHardcoded [warning] ((FrameLayout.LayoutParams) params).gravity = Gravity.RIGHT; BUG=None. Committed: https://crrev.com/21b5e19d993ae5e4b0830789966f75138f58f758 Cr-Commit-Position: refs/heads/master@{#320864}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwZoomControls.java View 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
wajahat
Pl. review, Thanks!
5 years, 9 months ago (2015-03-16 14:27:16 UTC) #2
wajahat
5 years, 9 months ago (2015-03-16 14:29:15 UTC) #4
boliu
lgtm https://codereview.chromium.org/1013713003/diff/1/android_webview/java/src/org/chromium/android_webview/AwZoomControls.java File android_webview/java/src/org/chromium/android_webview/AwZoomControls.java (right): https://codereview.chromium.org/1013713003/diff/1/android_webview/java/src/org/chromium/android_webview/AwZoomControls.java#newcode78 android_webview/java/src/org/chromium/android_webview/AwZoomControls.java:78: ((FrameLayout.LayoutParams) params).gravity = Gravity.RIGHT; I think this originally ...
5 years, 9 months ago (2015-03-16 20:40:18 UTC) #5
wajahat
On 2015/03/16 20:40:18, boliu wrote: > lgtm > > https://codereview.chromium.org/1013713003/diff/1/android_webview/java/src/org/chromium/android_webview/AwZoomControls.java > File android_webview/java/src/org/chromium/android_webview/AwZoomControls.java > (right): ...
5 years, 9 months ago (2015-03-17 04:16:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013713003/1
5 years, 9 months ago (2015-03-17 04:16:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 04:49:16 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 04:49:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21b5e19d993ae5e4b0830789966f75138f58f758
Cr-Commit-Position: refs/heads/master@{#320864}

Powered by Google App Engine
This is Rietveld 408576698