Ignore lint error RtlHardcoded for AwZoomControls

android_webview/java/src/org/chromium/android_webview/AwZoomControls.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview;
 
+import android.annotation.SuppressLint;
 import android.view.Gravity;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.FrameLayout;
 import android.widget.ZoomButtonsController;
 
 import org.chromium.content.browser.ContentViewCore.ZoomControlsDelegate;
 
 class AwZoomControls implements ZoomControlsDelegate {
 
@@ skipping 37 matching lines @@
             zoomController.setZoomInEnabled(canZoomIn);
             zoomController.setZoomOutEnabled(canZoomOut);
         }
     }
 
     // This method is used in tests. It doesn't modify the state of zoom controls.
     View getZoomControlsViewForTest() {
         return mZoomButtonsController != null ? mZoomButtonsController.getZoomControls() : null;
     }
 
+    @SuppressLint("RtlHardcoded")
     private ZoomButtonsController getZoomController() {
         if (mZoomButtonsController == null
                 && mAwContents.getSettings().shouldDisplayZoomControls()) {
             mZoomButtonsController = new ZoomButtonsController(
                     mAwContents.getContentViewCore().getContainerView());
             mZoomButtonsController.setOnZoomListener(new ZoomListener());
             // ZoomButtonsController positions the buttons at the bottom, but in
             // the middle. Change their layout parameters so they appear on the
             // right.
             View controls = mZoomButtonsController.getZoomControls();
             ViewGroup.LayoutParams params = controls.getLayoutParams();
             if (params instanceof FrameLayout.LayoutParams) {
                 ((FrameLayout.LayoutParams) params).gravity = Gravity.RIGHT;

[boliu, 2015/03/16 20:40:18]

I think this originally came from here:

https://android.googlesource.com/platform/frameworks/base/+/ics-mr1/core/java...

It's been like this since day one, and at this point maintaining backward
compatible behavior probably makes more sense than changing this to Gravity.END
(as lint suggests) to address RTL issues.

             }
         }
         return mZoomButtonsController;
     }
 
     private class ZoomListener implements ZoomButtonsController.OnZoomListener {
         @Override
         public void onVisibilityChanged(boolean visible) {
             if (visible) {
                 // Bring back the hidden zoom controls.
                 mZoomButtonsController.getZoomControls().setVisibility(View.VISIBLE);
                 updateZoomControls();
             }
         }
 
         @Override
         public void onZoom(boolean zoomIn) {
             if (zoomIn) {
                 mAwContents.zoomIn();
             } else {
                 mAwContents.zoomOut();
             }
             // ContentView will call updateZoomControls after its current page scale
             // is got updated from the native code.
         }
     }
 }