Source/bindings/tests/results/core/V8TestNode.cpp - Issue 1013643002: [bindings] Make sure v8::Isolate is being passed to toXXX() conversion routines as argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestNode.cpp

Issue 1013643002: [bindings] Make sure v8::Isolate is being passed to toXXX() conversion routines as argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestNode.cpp

diff --git a/Source/bindings/tests/results/core/V8TestNode.cpp b/Source/bindings/tests/results/core/V8TestNode.cpp

index 1f146a4b3b56a6c2cdc6cf23ea8e243f749b821e..37aae86883c6f8951b59bdb9dc800dd3e2536135 100644

--- a/Source/bindings/tests/results/core/V8TestNode.cpp

+++ b/Source/bindings/tests/results/core/V8TestNode.cpp

@@ -148,7 +148,7 @@ static void hrefByteStringAttributeSetter(v8::Local<v8::Value> v8Value, const v8

v8::Local<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "hrefByteString", "TestNode", holder, info.GetIsolate());

TestNode* impl = V8TestNode::toImpl(holder);

- V8StringResource<> cppValue = toByteString(v8Value, exceptionState);

+ V8StringResource<> cppValue = toByteString(info.GetIsolate(), v8Value, exceptionState);

if (exceptionState.throwIfNeeded())

return;

impl->setHrefByteString(cppValue);