Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: Source/core/html/track/TextTrackCue.h

Issue 1013393004: Eliminate TextTrackCue::updateDisplayTree() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: coerce m_isPastNode to bool Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/TextTrackContainer.cpp ('k') | Source/core/html/track/vtt/VTTCue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrackCue.h
diff --git a/Source/core/html/track/TextTrackCue.h b/Source/core/html/track/TextTrackCue.h
index d55d06b555076b540d48a2e341e8f5b404d5dd9d..2c8cc769de0a9a67262aa5e77b5b42c326de29ea 100644
--- a/Source/core/html/track/TextTrackCue.h
+++ b/Source/core/html/track/TextTrackCue.h
@@ -80,12 +80,16 @@ public:
bool isActive() const { return m_isActive; }
void setIsActive(bool active) { m_isActive = active; }
+ // Updates the display tree and appends it to container if it has not
+ // already been added.
virtual void updateDisplay(HTMLDivElement& container) = 0;
- // FIXME: Consider refactoring to eliminate or merge the following three members.
- // https://code.google.com/p/chromium/issues/detail?id=322434
- virtual void updateDisplayTree(double movieTime) = 0;
+ // Marks the nodes of the display tree as past or future relative to
+ // movieTime. If updateDisplay() has not been called there is no display
+ // tree and nothing is done.
+ virtual void updatePastAndFutureNodes(double movieTime) = 0;
+ // FIXME: Refactor to eliminate removeDisplayTree(). https://crbug.com/322434
enum RemovalNotification {
DontNotifyRegion,
NotifyRegion
« no previous file with comments | « Source/core/html/track/TextTrackContainer.cpp ('k') | Source/core/html/track/vtt/VTTCue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698