Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: Source/core/html/track/TextTrackCue.h

Issue 1013393004: Eliminate TextTrackCue::updateDisplayTree() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: coerce m_isPastNode to bool Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/track/TextTrackContainer.cpp ('k') | Source/core/html/track/vtt/VTTCue.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 unsigned cueIndex(); 73 unsigned cueIndex();
74 void updateCueIndex(unsigned cueIndex) { m_cueIndex = cueIndex; } 74 void updateCueIndex(unsigned cueIndex) { m_cueIndex = cueIndex; }
75 void invalidateCueIndex(); 75 void invalidateCueIndex();
76 76
77 using EventTarget::dispatchEvent; 77 using EventTarget::dispatchEvent;
78 virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override; 78 virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
79 79
80 bool isActive() const { return m_isActive; } 80 bool isActive() const { return m_isActive; }
81 void setIsActive(bool active) { m_isActive = active; } 81 void setIsActive(bool active) { m_isActive = active; }
82 82
83 // Updates the display tree and appends it to container if it has not
84 // already been added.
83 virtual void updateDisplay(HTMLDivElement& container) = 0; 85 virtual void updateDisplay(HTMLDivElement& container) = 0;
84 86
85 // FIXME: Consider refactoring to eliminate or merge the following three mem bers. 87 // Marks the nodes of the display tree as past or future relative to
86 // https://code.google.com/p/chromium/issues/detail?id=322434 88 // movieTime. If updateDisplay() has not been called there is no display
87 virtual void updateDisplayTree(double movieTime) = 0; 89 // tree and nothing is done.
90 virtual void updatePastAndFutureNodes(double movieTime) = 0;
88 91
92 // FIXME: Refactor to eliminate removeDisplayTree(). https://crbug.com/32243 4
89 enum RemovalNotification { 93 enum RemovalNotification {
90 DontNotifyRegion, 94 DontNotifyRegion,
91 NotifyRegion 95 NotifyRegion
92 }; 96 };
93 virtual void removeDisplayTree(RemovalNotification = NotifyRegion) = 0; 97 virtual void removeDisplayTree(RemovalNotification = NotifyRegion) = 0;
94 98
95 virtual const AtomicString& interfaceName() const override; 99 virtual const AtomicString& interfaceName() const override;
96 100
97 #ifndef NDEBUG 101 #ifndef NDEBUG
98 virtual String toString() const = 0; 102 virtual String toString() const = 0;
(...skipping 19 matching lines...) Expand all
118 122
119 unsigned m_cueIndex; 123 unsigned m_cueIndex;
120 124
121 bool m_isActive : 1; 125 bool m_isActive : 1;
122 bool m_pauseOnExit : 1; 126 bool m_pauseOnExit : 1;
123 }; 127 };
124 128
125 } // namespace blink 129 } // namespace blink
126 130
127 #endif // TextTrackCue_h 131 #endif // TextTrackCue_h
OLDNEW
« no previous file with comments | « Source/core/html/track/TextTrackContainer.cpp ('k') | Source/core/html/track/vtt/VTTCue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698