Preventing the default action on 'mousemove' listener shouldn't prevent selection

Preventing the default action on 'mousemove' listener shouldn't prevent selection

As per the spec, mousemove has no default action: 
http://www.w3.org/TR/DOM-Level-3-Events/#event-type-mousemove.
Hence preventing the default action on mousemove should not 
prevent selection/drag from happening. Made changes to 
allow drag operation irrespective of mousemove event 
cancellation similar to behavior of other browsers.

BUG=346473
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192855

[ramya.v, 2015-03-19 04:27:00]

ramya.v@samsung.com changed reviewers:
+ leviw@chromium.org, ojan@chromium.org

[ramya.v, 2015-03-19 04:27:00]

PTAL!

[leviw_travelin_and_unemployed, 2015-03-19 12:56:12]

https://codereview.chromium.org/1013303003/diff/1/LayoutTests/fast/events/dra...
File LayoutTests/fast/events/drag-on-mouse-move-cancelled.html (right):

https://codereview.chromium.org/1013303003/diff/1/LayoutTests/fast/events/dra...
LayoutTests/fast/events/drag-on-mouse-move-cancelled.html:1: <script>
Nit: doctype.

https://codereview.chromium.org/1013303003/diff/1/LayoutTests/fast/events/dra...
LayoutTests/fast/events/drag-on-mouse-move-cancelled.html:2: window.onload =
function(evt) {
You don't need an onload handler. Just put the script at the end of the page.

https://codereview.chromium.org/1013303003/diff/1/LayoutTests/fast/events/dra...
LayoutTests/fast/events/drag-on-mouse-move-cancelled.html:32: var result =
range.toString().length > 0 ? "SUCCESS" : "FAILED";
You should use js-test.js instead of rolling this logic yourself.

https://codereview.chromium.org/1013303003/diff/1/LayoutTests/fast/events/dra...
LayoutTests/fast/events/drag-on-mouse-move-cancelled.html:41: is to be prevented
on defaultPrevent.</p>
"defaultPrevent"

Also since this is easy to test manually, you should explain how.

[ramya.v, 2015-03-24 05:29:20]

Made Changes as per review comments.
PTAL!

Thanks

https://codereview.chromium.org/1013303003/diff/1/LayoutTests/fast/events/dra...
File LayoutTests/fast/events/drag-on-mouse-move-cancelled.html (right):

https://codereview.chromium.org/1013303003/diff/1/LayoutTests/fast/events/dra...
LayoutTests/fast/events/drag-on-mouse-move-cancelled.html:1: <script>
On 2015/03/19 12:56:11, leviw wrote:
> Nit: doctype.

Done.

https://codereview.chromium.org/1013303003/diff/1/LayoutTests/fast/events/dra...
LayoutTests/fast/events/drag-on-mouse-move-cancelled.html:2: window.onload =
function(evt) {
On 2015/03/19 12:56:11, leviw wrote:
> You don't need an onload handler. Just put the script at the end of the page.

Done.

https://codereview.chromium.org/1013303003/diff/1/LayoutTests/fast/events/dra...
LayoutTests/fast/events/drag-on-mouse-move-cancelled.html:32: var result =
range.toString().length > 0 ? "SUCCESS" : "FAILED";
On 2015/03/19 12:56:11, leviw wrote:
> You should use js-test.js instead of rolling this logic yourself.

Done.

https://codereview.chromium.org/1013303003/diff/1/LayoutTests/fast/events/dra...
LayoutTests/fast/events/drag-on-mouse-move-cancelled.html:41: is to be prevented
on defaultPrevent.</p>
On 2015/03/19 12:56:11, leviw wrote:
> "defaultPrevent"
> 
> Also since this is easy to test manually, you should explain how.

Done.

[rwlbuis, 2015-03-24 14:00:54]

rob.buis@samsung.com changed reviewers:
+ rob.buis@samsung.com

[rwlbuis, 2015-03-24 14:00:54]

Ramya, I think you should add some sentences to your commit log explaining the
patch. Also, can you shorten the long Subject line? :)

[ramya.v, 2015-03-25 03:14:35]

On 2015/03/24 14:00:54, rwlbuis wrote:
> Ramya, I think you should add some sentences to your commit log explaining the
> patch. Also, can you shorten the long Subject line? :)

@Rob
Updated the subject and description.
PTAL!

Thanks

[leviw_travelin_and_unemployed, 2015-03-25 16:45:39]

Ideally your subject line is a very short summary that doesn't wrap. That's the
line that'll be visible in various dashboards later.

[ramya.v, 2015-03-26 03:18:57]

On 2015/03/25 16:45:39, leviw wrote:
> Ideally your subject line is a very short summary that doesn't wrap. That's
the
> line that'll be visible in various dashboards later.

@leviw
Is the current subject line fine? Should I make any changes?

[leviw_travelin_and_unemployed, 2015-03-26 18:37:58]

On 2015/03/26 at 03:18:57, ramya.v wrote:
> On 2015/03/25 16:45:39, leviw wrote:
> > Ideally your subject line is a very short summary that doesn't wrap. That's
the
> > line that'll be visible in various dashboards later.
> 
> @leviw
> Is the current subject line fine? Should I make any changes?

s/doesnot/does not/ (or doesn't)

Instead of a subject that describes the bug, your subject should describe the
fix.

Also, the first line of your description should be a copy of the subject line.

[ramya.v, 2015-03-27 03:09:24]

On 2015/03/26 18:37:58, leviw wrote:
> On 2015/03/26 at 03:18:57, ramya.v wrote:
> > On 2015/03/25 16:45:39, leviw wrote:
> > > Ideally your subject line is a very short summary that doesn't wrap.
That's
> the
> > > line that'll be visible in various dashboards later.
> > 
> > @leviw
> > Is the current subject line fine? Should I make any changes?
> 
> s/doesnot/does not/ (or doesn't)
> 
> Instead of a subject that describes the bug, your subject should describe the
> fix.
> 
> Also, the first line of your description should be a copy of the subject line.

@leviw
Modified as per review comments. PTAL!
Thanks.

[leviw_travelin_and_unemployed, 2015-03-27 19:13:34]

https://codereview.chromium.org/1013303003/diff/60001/Source/core/page/EventH...
File Source/core/page/EventHandler.cpp (right):

https://codereview.chromium.org/1013303003/diff/60001/Source/core/page/EventH...
Source/core/page/EventHandler.cpp:1505: // irrespective of event is cancelled or
not there should be no differenece
"irrespective of event is cancelled or not there should be no differenece"

This statement isn't proper English and difference is misspelled.

[ramya.v, 2015-03-30 03:19:36]

@leviw,
Modified as per review comments
PTAL!

Thanks

https://codereview.chromium.org/1013303003/diff/60001/Source/core/page/EventH...
File Source/core/page/EventHandler.cpp (right):

https://codereview.chromium.org/1013303003/diff/60001/Source/core/page/EventH...
Source/core/page/EventHandler.cpp:1505: // irrespective of event is cancelled or
not there should be no differenece
On 2015/03/27 19:13:34, leviw wrote:
> "irrespective of event is cancelled or not there should be no differenece"
> 
> This statement isn't proper English and difference is misspelled.

Done.

[leviw_travelin_and_unemployed, 2015-03-30 17:27:51]

https://codereview.chromium.org/1013303003/diff/80001/Source/core/page/EventH...
File Source/core/page/EventHandler.cpp (right):

https://codereview.chromium.org/1013303003/diff/80001/Source/core/page/EventH...
Source/core/page/EventHandler.cpp:1505: // irrespective of whether event is
cancelled or not there should not
How about "Since there is no default action for the mousemove event, issue a
mouse dragged event irrespective of whether the event is cancelled."

[ramya.v, 2015-03-31 04:52:14]

@leviw

Modified as per review comments. PTAL!

Thanks.

https://codereview.chromium.org/1013303003/diff/80001/Source/core/page/EventH...
File Source/core/page/EventHandler.cpp (right):

https://codereview.chromium.org/1013303003/diff/80001/Source/core/page/EventH...
Source/core/page/EventHandler.cpp:1505: // irrespective of whether event is
cancelled or not there should not
On 2015/03/30 17:27:51, leviw wrote:
> How about "Since there is no default action for the mousemove event, issue a
> mouse dragged event irrespective of whether the event is cancelled."

Done.

[leviw_travelin_and_unemployed, 2015-03-31 17:58:47]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-03-31 17:58:48]

lgtm.

[commit-bot: I haz the power, 2015-03-31 17:59:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1013303003/100001

[commit-bot: I haz the power, 2015-03-31 21:45:34]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192855

[Rick Byers, 2015-05-14 01:57:12]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1145433002/ by rbyers@chromium.org.

The reason for reverting is: Revert because there are applications (like Google
maps - http://crbug.com/485892) which are relying on disabling text selection /
drag and drop but are forced to avoid cancelling mousedown (due to
http://crbug.com/269917)..