Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1013263002: Update Google Input Tools. (Closed)

Created:
5 years, 9 months ago by Peter Wen
Modified:
5 years, 9 months ago
Reviewers:
rsadam, bshe
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Google Input Tools. BUG=450050 Committed: https://crrev.com/a13b511596a13af3b47785e283c42cd0d5520e84 Cr-Commit-Position: refs/heads/master@{#320989}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -276 lines) Patch
M third_party/google_input_tools/README.chromium View 1 chunk +2 lines, -2 lines 2 comments Download
M third_party/google_input_tools/inputview.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/_locales/da/messages.json View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/adapter.js View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/controller.js View 32 chunks +48 lines, -45 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/css.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/elements/content/altdataview.js View 7 chunks +19 lines, -16 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/elements/content/candidate.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/elements/content/canvasview.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/elements/content/gesturecanvasview.js View 10 chunks +245 lines, -115 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/elements/content/material/spacekey.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/elements/content/swipeview.js View 20 chunks +82 lines, -68 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/elements/content/switcherkey.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/featurename.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/imewindows/accents.js View 5 chunks +3 lines, -5 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/inputview/layouts/material/spacerow.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/google_input_tools/src/chrome/os/message/name.js View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/google_input_tools/src/chrome/os/message/source.js View 1 chunk +14 lines, -8 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/message/type.js View 4 chunks +72 lines, -4 lines 0 comments Download
M third_party/google_input_tools/src/chrome/os/statistics.js View 4 chunks +66 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Peter Wen
5 years, 9 months ago (2015-03-17 18:15:07 UTC) #2
bshe
lgtm https://codereview.chromium.org/1013263002/diff/1/third_party/google_input_tools/README.chromium File third_party/google_input_tools/README.chromium (right): https://codereview.chromium.org/1013263002/diff/1/third_party/google_input_tools/README.chromium#newcode4 third_party/google_input_tools/README.chromium:4: Version: 1.0.4.3 version number decreased? Do you mean ...
5 years, 9 months ago (2015-03-17 20:37:36 UTC) #3
Peter Wen
PTAL just to make sure you're both aware of the version sync. https://codereview.chromium.org/1013263002/diff/1/third_party/google_input_tools/README.chromium File third_party/google_input_tools/README.chromium ...
5 years, 9 months ago (2015-03-17 20:53:01 UTC) #4
bshe
On 2015/03/17 20:53:01, Peter Wen wrote: > PTAL just to make sure you're both aware ...
5 years, 9 months ago (2015-03-17 20:54:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013263002/1
5 years, 9 months ago (2015-03-17 21:26:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 22:03:59 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 22:04:29 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a13b511596a13af3b47785e283c42cd0d5520e84
Cr-Commit-Position: refs/heads/master@{#320989}

Powered by Google App Engine
This is Rietveld 408576698