Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/google_input_tools/src/chrome/os/inputview/imewindows/accents.js

Issue 1013263002: Update Google Input Tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/google_input_tools/src/chrome/os/inputview/imewindows/accents.js
diff --git a/third_party/google_input_tools/src/chrome/os/inputview/imewindows/accents.js b/third_party/google_input_tools/src/chrome/os/inputview/imewindows/accents.js
index 8a89e889fae53f7a7e7ca786495cb35771eb78a2..f9ecf80773e68f41bd6241ed30c640c43ce7b006 100644
--- a/third_party/google_input_tools/src/chrome/os/inputview/imewindows/accents.js
+++ b/third_party/google_input_tools/src/chrome/os/inputview/imewindows/accents.js
@@ -16,7 +16,6 @@ goog.provide('i18n.input.chrome.inputview.Accents');
goog.require('goog.dom');
goog.require('goog.dom.TagName');
goog.require('goog.dom.classlist');
-goog.require('goog.math.Coordinate');
goog.require('goog.style');
goog.require('i18n.input.chrome.inputview.Css');
goog.require('i18n.input.chrome.inputview.util');
@@ -61,7 +60,7 @@ Accents.highlightItem_ = function(x, y, offset) {
if (Accents.highlightedItem_ != highlightedItem) {
if (Accents.highlightedItem_) {
goog.dom.classlist.remove(Accents.highlightedItem_,
- i18n.input.chrome.inputview.Css.ELEMENT_HIGHLIGHT);
+ i18n.input.chrome.inputview.Css.ELEMENT_HIGHLIGHT);
}
Accents.highlightedItem_ = highlightedItem;
if (Accents.highlightedItem_ &&
@@ -78,6 +77,7 @@ Accents.highlightItem_ = function(x, y, offset) {
* @param {number} x The x position of finger in screen coordinate system.
* @param {number} y The y position of finger in screen coordinate system.
* @param {number} offset The offset to cancel highlight.
+ * @return {Element} .
* @private
*/
Accents.getHighlightedItem_ = function(x, y, offset) {
@@ -130,9 +130,6 @@ Accents.setAccents_ = function(accents, numOfColumns, numOfRows, width,
var TagName = goog.dom.TagName;
var dom = goog.dom.getDomHelper();
var container = dom.createDom(TagName.DIV, Css.ACCENT_CONTAINER);
- goog.dom.setProperties(container, {
- 'id' : 'container'
- });
container.id = 'container';
var orderedAccents = Accents.reorderAccents_(accents, numOfColumns, numOfRows,
@@ -179,6 +176,7 @@ Accents.setAccents_ = function(accents, numOfColumns, numOfRows, width,
* @param {!number} numOfColumns The number of colums of this accents window.
* @param {!number} numOfRows The number of rows of this accents window.
* @param {number} startKeyIndex The index of the start key in bottom row.
+ * @return {!Array.<string>} .
* @private
*/
Accents.reorderAccents_ = function(accents, numOfColumns, numOfRows,

Powered by Google App Engine
This is Rietveld 408576698